Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added Emacs C++ marker to header comments [skip ci] #6346

Merged
merged 1 commit into from
Aug 7, 2024
Merged

added Emacs C++ marker to header comments [skip ci] #6346

merged 1 commit into from
Aug 7, 2024

Conversation

firewave
Copy link
Collaborator

No description provided.

@firewave
Copy link
Collaborator Author

I think this looks reasonable and quite unintrusive.

@chrchr-github
Copy link
Collaborator

We could also rename to .hpp/.hh.

@firewave
Copy link
Collaborator Author

We could also rename to .hpp/.hh.

That would be very intrusive and I want to avoid that.

I associate .hpp with template-heavy (sometimes standalone) headers and it doesn't appear to be in use that common. .hh I would consider quite an outlier.

@firewave firewave mentioned this pull request May 22, 2024
Merged
@firewave firewave changed the title added Emacs C++ marker to comments added Emacs C++ marker to comments [skip ci] May 22, 2024
@firewave firewave changed the title added Emacs C++ marker to comments [skip ci] added Emacs C++ marker to comments May 22, 2024
@firewave firewave changed the title added Emacs C++ marker to comments added Emacs C++ marker to header comments May 23, 2024
@firewave firewave marked this pull request as ready for review May 24, 2024 07:14
@firewave firewave marked this pull request as draft May 26, 2024 20:17
@firewave
Copy link
Collaborator Author

Made a draft since a lot of headers are being added.

@firewave firewave marked this pull request as ready for review July 22, 2024 14:39
@firewave firewave changed the title added Emacs C++ marker to header comments added Emacs C++ marker to header comments [skip ci] Jul 22, 2024
danmar
danmar approved these changes Aug 7, 2024
View reviewed changes
Copy link
Owner

@danmar danmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@firewave firewave merged commit 89434e1 into danmar:main Aug 7, 2024
63 checks passed
@firewave firewave deleted the comments-x branch August 7, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danmar danmar danmar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@firewave @chrchr-github @danmar