Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TokenList: avoid Path::identify() being called with empty filename from determineCppC() #6326

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

firewave
Copy link
Collaborator

No description provided.

@firewave
Copy link
Collaborator Author

firewave commented Apr 22, 2024

Encountered while working on #6324 with e.g. /usr/include/poll.h.

Still needs a unit test and separate PR for simplecpp.

@firewave
Copy link
Collaborator Author

Requires danmar/simplecpp#349 and danmar/simplecpp#350 to be merged from upstream.

@firewave firewave force-pushed the identify-empty branch 3 times, most recently from cd0b7c7 to 690e4ae Compare April 24, 2024 17:16
@firewave firewave marked this pull request as ready for review April 24, 2024 17:17
@firewave firewave merged commit ca94527 into danmar:main Apr 25, 2024
64 checks passed
@firewave firewave deleted the identify-empty branch April 25, 2024 17:58
firewave added a commit to firewave/cppcheck that referenced this pull request May 23, 2024
…from `determineCppC()` (danmar#6326)

(cherry picked from commit ca94527)
firewave added a commit to firewave/cppcheck that referenced this pull request May 24, 2024
…from `determineCppC()` (danmar#6326)

(cherry picked from commit ca94527)
danmar pushed a commit that referenced this pull request May 26, 2024
…from `determineCppC()` (#6326) (#6429)

(cherry picked from commit ca94527)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants