Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iwyu.yml: treat explicit clang include directory in clang-tidy invocation as a system include / cleaned up includes #5983

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

firewave
Copy link
Collaborator

@firewave firewave commented Feb 14, 2024

This gets rid of false positives which suggested to replace the proper C++ header with a C one (e.g. climits -> limits.h).

@firewave firewave changed the title iwyu.yml: removed unnecessary clang include directory from clang-tidy invocation iwyu.yml: treat explicit clang include directory in clang-tidy invocation as a system include Feb 14, 2024
@firewave firewave changed the title iwyu.yml: treat explicit clang include directory in clang-tidy invocation as a system include iwyu.yml: treat explicit clang include directory in clang-tidy invocation as a system include / cleaned up includes Feb 14, 2024
@firewave
Copy link
Collaborator Author

This is done but waiting for some more of my upcoming PRs to hit as some of them might have missed some include changes.

@firewave firewave force-pushed the iwyu-yyy branch 2 times, most recently from f37eddb to 02fa7f5 Compare February 29, 2024 17:40
@firewave firewave marked this pull request as ready for review February 29, 2024 17:40
@firewave firewave marked this pull request as draft March 1, 2024 14:28
@firewave firewave marked this pull request as ready for review March 1, 2024 15:07
@firewave
Copy link
Collaborator Author

firewave commented Mar 1, 2024

GitHub is currently not behaving well. So builds might need to be cancelled and restarted later.

@chrchr-github chrchr-github merged commit 2464a9d into danmar:main Mar 4, 2024
64 checks passed
@firewave firewave deleted the iwyu-yyy branch March 4, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants