Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #12034 - release-windows.yml: specify proper openssl tool #5522

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

firewave
Copy link
Collaborator

@firewave firewave commented Oct 6, 2023

No description provided.

@firewave
Copy link
Collaborator Author

firewave commented Oct 6, 2023

The installer still needs to be adjusted for the new files.

I am also seeing this in the Qt installation:

C:\hostedtoolcache\windows\Python\3.11.5\x64\python.exe -m aqt install-tool windows desktop tools_opensslv3_x64 --outputdir D:\a\cppcheck/Qt
aqtinstall(aqt) v2.1.0 on Python 3.11.5 [CPython MSC v.1936 64 bit (AMD64)]
Specified target combination is not valid: windows tools_opensslv3_x64 qt.tools.opensslv3.win_x64

@firewave
Copy link
Collaborator Author

firewave commented Oct 8, 2023

We should merge #4669 for this as it will greatly help with testing this.

@firewave
Copy link
Collaborator Author

firewave commented Oct 9, 2023

We should merge #4669 for this as it will greatly help with testing this.

That wasn't necessary. Also it requires this fix to be working again.

I am also seeing this in the Qt installation:

C:\hostedtoolcache\windows\Python\3.11.5\x64\python.exe -m aqt install-tool windows desktop tools_opensslv3_x64 --outputdir D:\a\cppcheck/Qt
aqtinstall(aqt) v2.1.0 on Python 3.11.5 [CPython MSC v.1936 64 bit (AMD64)]
Specified target combination is not valid: windows tools_opensslv3_x64 qt.tools.opensslv3.win_x64

jurplel/install-qt-action#209

@firewave
Copy link
Collaborator Author

firewave commented Oct 9, 2023

See https://github.com/danmar/cppcheck/actions/runs/6453915580 for the successful build based on this code.

@danmar You need to cherry-pick this in case you want to release another 2.12.x version.

@firewave firewave marked this pull request as ready for review October 9, 2023 08:18
@chrchr-github chrchr-github merged commit c969c33 into danmar:main Oct 9, 2023
73 checks passed
@firewave firewave deleted the release-win-qt branch October 9, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants