-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #12039 FP knownConditionTrueFalse #5513
Conversation
If the last commit in a PR s flagged as "skip ci" the PR is not build and it won't show the checks even if a previous build/push/version was successful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Does it make sense to turn a symbolic value into a bound value? @pfultz2 |
I think so, we create symbolic bound values for conditions like |
lib/valueflow.cpp
Outdated
@@ -1858,6 +1858,7 @@ static void valueFlowImpossibleValues(TokenList& tokenList, const Settings* sett | |||
for (const Token* tok2 : tokens) { | |||
if (tok2->hasKnownIntValue()) { | |||
values.emplace_back(); | |||
values.back().intvalue = tok2->getKnownIntValue(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make more sense to just do values.push_pack(tok2->values().front())
?
No description provided.