Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed #11483 (FN unusedFunction for method with inline implementation) #5457

Merged
merged 6 commits into from
Sep 20, 2023
Merged

fixed #11483 (FN unusedFunction for method with inline implementation) #5457

merged 6 commits into from
Sep 20, 2023

Conversation

firewave
Copy link
Collaborator

No description provided.

@firewave
Copy link
Collaborator Author

This restarts #4692.

@firewave
Copy link
Collaborator Author

The suppressions work fine in headers. No idea what the initial issue was or maybe it was fixed.

@firewave firewave mentioned this pull request Sep 18, 2023
Closed
@firewave
Copy link
Collaborator Author

firewave commented Sep 18, 2023 •
edited
Loading

I still need to file tickets for the getArrayLength() issues.

https://trac.cppcheck.net/ticket/11999 for the seemingly wrong line for the suppression.
getArrayLength() is actually unused as it is only used in test and conditional code.

@firewave firewave marked this pull request as ready for review September 18, 2023 08:06
@firewave firewave changed the title fixed #11483 fixed #11483 (FN unusedFunction for method with inline implementation) Sep 18, 2023
@firewave
Copy link
Collaborator Author

The unreadVariable false negative is already tracked in https://trac.cppcheck.net/ticket/8433.

@danmar danmar merged commit f49fedb into danmar:main Sep 20, 2023
72 checks passed
@firewave firewave deleted the unused-11483 branch September 20, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrchr-github chrchr-github chrchr-github left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@firewave @chrchr-github @danmar