-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #11438 MathLib error on user defined literals #5448
Conversation
Co-authored-by: gerboengels
This was not built since the last commit (which is the one which triggers stuff) has the I am also not sure if the co-author tag works within the PR message. That is usually put in commit messages. But as this becomes the commit message it should work...I guess. I adjusted the tag to adhere to the correct format ( Update: If it is working you see multiple icons on the commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
It worked! 😃 Sorry for being on this but as I caused this and somebody else picked up which I should have been looking into I wanted the work to have the proper credits. |
We need to remember to adjust the simplecpp implementation as well. |
Based on #4701, #5418
A helper function for the
isdigit()
test should be introduced on the simplecpp side.Co-authored-by: gerboengels [email protected]