Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #11438 MathLib error on user defined literals #5448

Merged
merged 6 commits into from
Sep 15, 2023

Conversation

chrchr-github
Copy link
Collaborator

@chrchr-github chrchr-github commented Sep 13, 2023

Based on #4701, #5418

A helper function for the isdigit() test should be introduced on the simplecpp side.

Co-authored-by: gerboengels [email protected]

@firewave
Copy link
Collaborator

firewave commented Sep 13, 2023

This was not built since the last commit (which is the one which triggers stuff) has the [skip ci] suffix.

I am also not sure if the co-author tag works within the PR message. That is usually put in commit messages. But as this becomes the commit message it should work...I guess.

I adjusted the tag to adhere to the correct format (Co-authored-by: gerboengels <[email protected]>) but it is shown in a weird way so I guess it does not work...

Update: If it is working you see multiple icons on the commit.

Copy link
Owner

@danmar danmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chrchr-github chrchr-github merged commit 50ba506 into danmar:main Sep 15, 2023
72 checks passed
@chrchr-github chrchr-github deleted the chr_Fix11438 branch September 15, 2023 08:00
@firewave
Copy link
Collaborator

I adjusted the tag to adhere to the correct format (Co-authored-by: gerboengels <[email protected]>) but it is shown in a weird way so I guess it does not work...

It worked! 😃

Sorry for being on this but as I caused this and somebody else picked up which I should have been looking into I wanted the work to have the proper credits.

@firewave
Copy link
Collaborator

We need to remember to adjust the simplecpp implementation as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants