Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider pcre debug suffix for Windows #5429

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

MartinDelille
Copy link
Contributor

I'm suggesting this patch from the conan recipe: https://github.com/conan-io/conan-center-index/blob/afcf3ba/recipes/cppcheck/all/patches/0003-pcre-debuglib-name.patch

I just added the latest version without applying it to see if it works: conan-io/conan-center-index#19724

@firewave
Copy link
Collaborator

firewave commented Sep 10, 2023

Looks reasonable.

Still, could you please provide the actual error you are encountering and some more context about what build configuration is actually failing? Thanks.

@danmar Might make sense to backport this for the next 2.12.x after this was merged.

@MartinDelille
Copy link
Contributor Author

The error has been reproduced here:

https://github.com/eirikb/proof-of-conan/actions/runs/6147603900/job/16679475672#step:11:726

@firewave firewave merged commit a87e9e1 into danmar:main Sep 12, 2023
72 checks passed
@MartinDelille MartinDelille deleted the pcre-debug-suffix branch September 15, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants