refs #11928 / refs #10045 / fixes #11794 - generate `limits.h`/`climits` defines from platform #5414

firewave · 2023-09-07T23:56:21Z

No description provided.

firewave · 2023-10-02T08:25:27Z

The defines generated by defines.sh cannot be passed on to Cppcheck yet - I added https://trac.cppcheck.net/ticket/12028 about that.

The external scripts/logic should at some point be inlined into Cppcheck so you would only have to specify the compiler and no more other files. See https://trac.cppcheck.net/ticket/8956 about that.

firewave · 2023-10-02T08:35:45Z

I don't know to to make the warnings in the added integerOverflow2 test appear. I somehow need to invoke the preprocessor first and I have no idea how to do that.

firewave · 2023-10-04T12:28:48Z

I don't know to to make the warnings in the added integerOverflow2 test appear. I somehow need to invoke the preprocessor first and I have no idea how to do that.

@chrchr-github Any pointers on what to do here?

chrchr-github · 2023-10-04T18:46:01Z

I don't know to to make the warnings in the added integerOverflow2 test appear. I somehow need to invoke the preprocessor first and I have no idea how to do that.

@chrchr-github Any pointers on what to do here?

There is a checkP() function in TestOther. Can you call that?

firewave · 2023-10-04T19:06:28Z

There is a checkP() function in TestOther. Can you call that?

That was obvious. I did not look at the code at all before. Unfortunately that once again uses custom preprocessing which does not match the production one.

That code is also redundant as hell so I will clean that up first.

danmar · 2023-10-12T10:33:39Z

tools/defines/float.c

+
+int main(void)
+{
+    PRINT_DEF(FLT_RADIX, d);


What is the purpose of this? Is it the purpose that users will compile and run it? As far as I know this approach will not work in a avr controller for instance. Maybe an alternative would be to just preprocess a file with the target compiler.

What is the purpose of this?

It has multiple purposes:

for testing/development

for invoking via the add run_cppcheck.sh (not yet integrated / for developers/advanced user)

for invoking via the proposed --compiler= option (https://trac.cppcheck.net/ticket/8956) to generate a whole "native" configuration for the analysis instead of relying on a fixed platform configuration (basically integrating the aforementioned script)

this could also be used used to generate some kind of project file/fixed configuration which holds all these information which could be generated once in cases where the compiler or related development files are not available (the avr8 case you mentioned)

This is very much WIP and will probably stay like this for quite a while but we gotta start somewhere. 😀

hmm I am a bit skeptic about merging this into the repo because of all the tools files.

If it's just something we are looking at in the near future and it will just be lying in the repo unused a year from now then it feels unfortunate.

The bash scripts are not portable.

And the solution for #8956 should be generic imho. It should be possible to use it to configure AVR/etc compiler defines.

How about breaking out the tools files into a separate PR ?

If the float.c is not executed.. only preprocessed. Then it can be used for embedded compilers also. My guess is that most compilers have a flag to only perform preprocessing.

Example usage would be:

<my-compiler> <preprocess-only flag> floats.c > compiler-defs.h cppcheck --compiler-defs=compiler-defs.h ..

How about breaking out the tools files into a separate PR ?

I would like to keep those together with the changes I did for the code and I based those on that output.

If it's just something we are looking at in the near future and it will just be lying in the repo unused a year from now then it feels unfortunate.

The bash scripts are not portable.

And the solution for #8956 should be generic imho. It should be possible to use it to configure AVR/etc compiler defines.

There's lots of unused and possibly broken stuff in the repo nobody has touched in years. Some of it is even being shipped in the official release. This is not to be part of the official distribution and it's the very first step - I am not sure how the next even looks like. ALso having the already finished parts available enabled other people to take a look.

Even though this isn't portable daca isn't either. And I think the first to integrate this with would be daca. But there's several other things I want to finish up first before taking a stab at that.

If the float.c is not executed.. only preprocessed.

That's a good point. So no compilation/execution is needed. I will adjust that in an upcoming PR.

danmar · 2023-10-19T16:32:21Z

There's lots of unused and possibly broken stuff in the repo nobody has touched in years.

yes I realize that. Probably most of it was added by me myself.

And I think the first to integrate this with would be daca

then I understand why you wrote bash scripts at least.

firewave · 2023-10-19T18:50:21Z

There's lots of unused and possibly broken stuff in the repo nobody has touched in years.

yes I realize that. Probably most of it was added by me myself.

I have no idea why I even mentioned that - it's a really bad argument - heck, it's not an argument at all. 😉

…m from compiler

…ines

danmar · 2023-10-21T15:21:08Z

ok I hope this is work in progress and proper cleanup fixing will be added later..

firewave · 2023-10-21T15:42:45Z

ok I hope this is work in progress and proper cleanup fixing will be added later..

You and me both. I am getting so sick that the local branches keep piling up...

firewave · 2023-10-21T15:50:49Z

This also (partially) fixes https://trac.cppcheck.net/ticket/10155.

firewave force-pushed the platform-limits branch 9 times, most recently from ac3be5a to fa29f38 Compare September 8, 2023 16:35

This was referenced Sep 9, 2023

moved some standard stuff from avr.cfg to std.cfg #5421

Merged

extracted hard-coded platform definitions to actual platform files #4325

Draft

firewave force-pushed the platform-limits branch from fa29f38 to e57c9d5 Compare September 12, 2023 19:46

firewave force-pushed the platform-limits branch from e57c9d5 to 3cd560c Compare September 25, 2023 06:40

firewave changed the title ~~generate limits defines from platform~~ refs #11928 / refs #10045 / fixes #11794 - generate limits defines from platform Oct 2, 2023

firewave force-pushed the platform-limits branch from 3cd560c to e9e66fc Compare October 2, 2023 08:34

firewave force-pushed the platform-limits branch from e9e66fc to 7dda08a Compare October 2, 2023 09:18

firewave changed the title ~~refs #11928 / refs #10045 / fixes #11794 - generate limits defines from platform~~ refs #11928 / refs #10045 / fixes #11794 - generate limits.h/climits defines from platform Oct 5, 2023

firewave mentioned this pull request Oct 8, 2023

std.cfg: remove wrong macro replacements for UINT32_C etc. #5527

Merged

firewave force-pushed the platform-limits branch 2 times, most recently from 92ddc99 to 9d2ef05 Compare October 11, 2023 09:31

firewave marked this pull request as ready for review October 11, 2023 09:31

danmar reviewed Oct 12, 2023

View reviewed changes

firewave force-pushed the platform-limits branch from 9d2ef05 to a92d72b Compare October 19, 2023 18:49

firewave force-pushed the platform-limits branch 2 times, most recently from 9271570 to c5fa742 Compare October 19, 2023 19:14

firewave added 5 commits October 21, 2023 11:12

generate limits defines from platform / added scripts to generate the…

7286888

…m from compiler

added script to generate platform XML

5738565

added script to run Cppcheck with run-time generated platform and def…

94d06b2

…ines

tools/defines/create_platform_cfg.sh: fixed SC2236 Shellcheck warnings

1969789

TestPlatform: fixed functionConst selfcheck warnings

41114b6

firewave force-pushed the platform-limits branch from c5fa742 to 41114b6 Compare October 21, 2023 09:12

danmar merged commit 3103736 into danmar:main Oct 21, 2023
74 checks passed

firewave deleted the platform-limits branch October 21, 2023 15:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refs #11928 / refs #10045 / fixes #11794 - generate `limits.h`/`climits` defines from platform #5414

refs #11928 / refs #10045 / fixes #11794 - generate `limits.h`/`climits` defines from platform #5414

firewave commented Sep 7, 2023

firewave commented Oct 2, 2023

firewave commented Oct 2, 2023

firewave commented Oct 4, 2023

chrchr-github commented Oct 4, 2023

firewave commented Oct 4, 2023

danmar Oct 12, 2023

firewave Oct 12, 2023

danmar Oct 13, 2023

danmar Oct 13, 2023 •

edited

Loading

firewave Oct 16, 2023

danmar commented Oct 19, 2023

firewave commented Oct 19, 2023

danmar commented Oct 21, 2023

firewave commented Oct 21, 2023

firewave commented Oct 21, 2023

refs #11928 / refs #10045 / fixes #11794 - generate limits.h/climits defines from platform #5414

refs #11928 / refs #10045 / fixes #11794 - generate limits.h/climits defines from platform #5414

Conversation

firewave commented Sep 7, 2023

firewave commented Oct 2, 2023

firewave commented Oct 2, 2023

firewave commented Oct 4, 2023

chrchr-github commented Oct 4, 2023

firewave commented Oct 4, 2023

danmar Oct 12, 2023

Choose a reason for hiding this comment

firewave Oct 12, 2023

Choose a reason for hiding this comment

danmar Oct 13, 2023

Choose a reason for hiding this comment

danmar Oct 13, 2023 • edited Loading

Choose a reason for hiding this comment

firewave Oct 16, 2023

Choose a reason for hiding this comment

danmar commented Oct 19, 2023

firewave commented Oct 19, 2023

danmar commented Oct 21, 2023

firewave commented Oct 21, 2023

firewave commented Oct 21, 2023

refs #11928 / refs #10045 / fixes #11794 - generate `limits.h`/`climits` defines from platform #5414

refs #11928 / refs #10045 / fixes #11794 - generate `limits.h`/`climits` defines from platform #5414

danmar Oct 13, 2023 •

edited

Loading