Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #11797 (Crash: filename mismatch) - skip missing files in Visual Studio projects #5411

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

firewave
Copy link
Collaborator

@firewave firewave commented Sep 7, 2023

No description provided.

@firewave
Copy link
Collaborator Author

firewave commented Sep 7, 2023

Still needs the test to be adjusted for filesystems which are case insensitive.

This just prevents the crash. Additional handling would be a heuristic to lowercase the filename and check that on case sensitive filesystems.

We also somehow need to propagate the skipping back so the analysis will error out. But we have nothing in place to report such errors during the command-line processing as that requires the settings to exist. But I have an idea about that will file a ticket.

@firewave
Copy link
Collaborator Author

firewave commented Sep 7, 2023

This exposed MacOS filesystem actually being case insensitive. I filed danmar/simplecpp#309 and https://trac.cppcheck.net/ticket/11926 about it.

@firewave firewave changed the title fixed #11797 (Crash: filename mismatch) - skip missing files in Visual Studio projects [skip ci] fixed #11797 (Crash: filename mismatch) - skip missing files in Visual Studio projects Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant