changed bool_to_string() to return const char* instead and use it in more cases
#5385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmar
reviewed
Sep 1, 2023
firewave
force-pushed
the
bool
branch
2 times, most recently
from
556e3df
to
fb5088f
Compare
danmar
reviewed
Sep 2, 2023
gui/projectfile.cpp
Outdated
| @@ -857,11 +858,11 @@ bool ProjectFile::write(const QString &filename) | |||
| } | |||
|
|
|||
| xmlWriter.writeStartElement(CppcheckXml::CheckHeadersElementName); | |||
| xmlWriter.writeCharacters(mCheckHeaders ? "true" : "false"); | |||
| xmlWriter.writeCharacters(QString::fromStdString(bool_to_string(mCheckHeaders))); | |||
There was a problem hiding this comment.
more unnecessary QString::fromStdString here
firewave
added
the
merge-after-next-release
firewave
removed
the
merge-after-next-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.