Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI-mingw.yml: use pre-installed MinGW / also use lld and ccache for faster builds #4400

Merged
merged 5 commits into from
Sep 4, 2023

Conversation

firewave
Copy link
Collaborator

@firewave firewave commented Aug 25, 2022

This used to be one of the longest running jobs because of the slow setup and linking. Now it will take only ~2 minutes if everything is cached with half the time taken up by the tests.

@firewave firewave changed the title CI-mingw.yml: removed MinGW setup step since it is pre-installed in windows-* images CI-mingw.yml: use pre-installed MinGW Aug 25, 2022
@firewave firewave force-pushed the mingw-ci branch 5 times, most recently from eab43fc to 586d271 Compare August 29, 2022 17:16
@firewave firewave force-pushed the mingw-ci branch 3 times, most recently from fe5ea3f to 9e8658b Compare September 25, 2022 20:16
chrchr-github added a commit to chrchr-github/cppcheck that referenced this pull request May 10, 2023
@firewave
Copy link
Collaborator Author

firewave commented Sep 1, 2023

Accidentally closed by having a Trac ticket match a GitHub PR - re-opening.

@firewave firewave reopened this Sep 1, 2023
@firewave firewave force-pushed the mingw-ci branch 4 times, most recently from c6d2964 to c29ac28 Compare September 2, 2023 13:36
@firewave firewave changed the title CI-mingw.yml: use pre-installed MinGW CI-mingw.yml: use pre-installed MinGW, lld and ccache for faster build Sep 2, 2023
@firewave firewave force-pushed the mingw-ci branch 2 times, most recently from 56e30ee to f755ca8 Compare September 2, 2023 13:53
@firewave firewave changed the title CI-mingw.yml: use pre-installed MinGW, lld and ccache for faster build CI-mingw.yml: use pre-installed MinGW / also use lld and ccache for faster builds Sep 2, 2023
@firewave firewave force-pushed the mingw-ci branch 2 times, most recently from 3869256 to 7acbe59 Compare September 2, 2023 14:02
@firewave
Copy link
Collaborator Author

firewave commented Sep 2, 2023

I have lowered the recursion limit for TestLeakAutoVarRecursiveCountLimit several times but I still keeps crashes with a stack overflow. I do not want to adjust the limit in the code since it was fine outside MSYS2 (and probably will be for all users which are not as memory limited as the CI) and (hopefully temporarily) disabled the test for MinGW instead.

@firewave firewave marked this pull request as ready for review September 2, 2023 14:05
@danmar
Copy link
Owner

danmar commented Sep 4, 2023

I feel I can merge this.. do you feel it's ready?

@firewave
Copy link
Collaborator Author

firewave commented Sep 4, 2023

I feel I can merge this.. do you feel it's ready?

Yup. That's why I marked it for review.

@danmar danmar merged commit c068c74 into danmar:main Sep 4, 2023
76 checks passed
@firewave firewave deleted the mingw-ci branch September 4, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants