diff --git a/.clang-tidy b/.clang-tidy index e1bae2cd2554..540d5a7e878a 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -45,7 +45,6 @@ Checks: > -modernize-replace-auto-ptr, -modernize-return-braced-init-list, -modernize-use-auto, - -modernize-use-equals-default, -modernize-use-trailing-return-type, -performance-avoid-endl, -performance-inefficient-string-concatenation, diff --git a/clang-tidy.md b/clang-tidy.md index 2311d2d3a97c..a2e2dd5db5e4 100644 --- a/clang-tidy.md +++ b/clang-tidy.md @@ -63,7 +63,6 @@ This does not appear to be useful as it is reported on very common code. It was decided not to apply these. -`modernize-use-equals-default`
`modernize-loop-convert`
These might change the behavior of code which might not be intended (need to file an upstream issue) diff --git a/gui/checkthread.cpp b/gui/checkthread.cpp index b45f30c6eb05..0a8fbf346319 100644 --- a/gui/checkthread.cpp +++ b/gui/checkthread.cpp @@ -86,14 +86,7 @@ static bool executeCommand(std::string exe, std::vector args, std:: CheckThread::CheckThread(ThreadResult &result) : mResult(result), mCppcheck(result, true, executeCommand) -{ - //ctor -} - -CheckThread::~CheckThread() -{ - //dtor -} +{} void CheckThread::check(const Settings &settings) { diff --git a/gui/checkthread.h b/gui/checkthread.h index d74ec2514a98..d246020bb618 100644 --- a/gui/checkthread.h +++ b/gui/checkthread.h @@ -46,7 +46,7 @@ class CheckThread : public QThread { Q_OBJECT public: explicit CheckThread(ThreadResult &result); - ~CheckThread() override; + ~CheckThread() override = default; /** * @brief Set settings for cppcheck diff --git a/gui/csvreport.cpp b/gui/csvreport.cpp index 36da50bbde57..740651cf06fd 100644 --- a/gui/csvreport.cpp +++ b/gui/csvreport.cpp @@ -30,9 +30,6 @@ CsvReport::CsvReport(const QString &filename) : Report(filename) {} -CsvReport::~CsvReport() -{} - bool CsvReport::create() { if (Report::create()) { diff --git a/gui/csvreport.h b/gui/csvreport.h index a2efdd93b0a8..42395adba971 100644 --- a/gui/csvreport.h +++ b/gui/csvreport.h @@ -39,7 +39,7 @@ class ErrorItem; class CsvReport : public Report { public: explicit CsvReport(const QString &filename); - ~CsvReport() override; + ~CsvReport() override = default; /** * @brief Create the report (file). diff --git a/gui/printablereport.cpp b/gui/printablereport.cpp index 9bcfff55c342..d9272632f454 100644 --- a/gui/printablereport.cpp +++ b/gui/printablereport.cpp @@ -27,9 +27,6 @@ PrintableReport::PrintableReport() : Report(QString()) {} -PrintableReport::~PrintableReport() -{} - bool PrintableReport::create() { return true; diff --git a/gui/printablereport.h b/gui/printablereport.h index 29fa008bf61b..d85724ce6a83 100644 --- a/gui/printablereport.h +++ b/gui/printablereport.h @@ -36,7 +36,7 @@ class ErrorItem; class PrintableReport : public Report { public: PrintableReport(); - ~PrintableReport() override; + ~PrintableReport() override = default; /** * @brief Create the report (file). diff --git a/lib/timer.h b/lib/timer.h index 1fe246f417da..34a5216d8d37 100644 --- a/lib/timer.h +++ b/lib/timer.h @@ -37,7 +37,7 @@ enum class SHOWTIME_MODES { class CPPCHECKLIB TimerResultsIntf { public: - virtual ~TimerResultsIntf() {} + virtual ~TimerResultsIntf() = default; virtual void addResults(const std::string& str, std::clock_t clocks) = 0; }; @@ -54,7 +54,7 @@ struct TimerResultsData { class CPPCHECKLIB TimerResults : public TimerResultsIntf { public: - TimerResults() {} + TimerResults() = default; void showResults(SHOWTIME_MODES mode) const; void addResults(const std::string& str, std::clock_t clocks) override;