Fix CID 1534125; String not null terminated in Path::getCurrentExecut…

…ablePath()
danmar · Aug 18, 2024 · cf91f51 · cf91f51
1 parent 9aa63a7
commit cf91f51
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/lib/path.cpp b/lib/path.cpp
@@ -164,7 +164,8 @@ std::string Path::getCurrentExecutablePath(const char* fallback)
 #else // Linux
         "/proc/self/exe";
 #endif
-    success = (readlink(procPath, buf, sizeof(buf)) != -1);
+    // readlink does not null-terminate the string if the buffer is too small, therefore write bufsize - 1
+    success = (readlink(procPath, buf, sizeof(buf) - 1) != -1);
 #endif
     return success ? std::string(buf) : std::string(fallback);
 }