Fix #12625 internalError with function typedefs (#6431)

danmar · May 23, 2024 · a182aa8 · a182aa8
1 parent 3983c0c
commit a182aa8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/tokenize.cpp b/lib/tokenize.cpp
@@ -517,7 +517,7 @@ const Token *Tokenizer::processFunc(const Token *tok2, bool inOperator) const
                 tok2 = tok2->next();
 
                 while (Token::Match(tok2, "*|&") &&
-                       !Token::Match(tok2->next(), ")|>"))
+                       !Token::Match(tok2->next(), "[)>,]"))
                     tok2 = tok2->next();
 
                 // skip over namespace

diff --git a/test/testsimplifytypedef.cpp b/test/testsimplifytypedef.cpp
@@ -56,6 +56,7 @@ class TestSimplifyTypedef : public TestFixture {
         TEST_CASE(cfunction1);
         TEST_CASE(cfunction2);
         TEST_CASE(cfunction3);
+        TEST_CASE(cfunction4);
         TEST_CASE(cfp1);
         TEST_CASE(cfp2);
         TEST_CASE(cfp4);
@@ -415,6 +416,12 @@ class TestSimplifyTypedef : public TestFixture {
         ASSERT_EQUALS("[file.c:2]: (portability) It is unspecified behavior to const qualify a function type.\n", errout_str());
     }
 
+    void cfunction4() {
+        const char code[] = "typedef int (func_t) (int);\n" // #12625
+                            "int f(int*, func_t*, int);\n";
+        ASSERT_EQUALS("int f ( int * , int ( * ) ( int ) , int ) ;", simplifyTypedefC(code));
+    }
+
     void cfp1() {
         const char code[] = "typedef void (*fp)(void * p);\n"
                             "fp x;";