From 9db3950b2ae4c55df8940fe60fb80f203a7d0c2a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Marjam=C3=A4ki?= <daniel.marjamaki@gmail.com>
Date: Thu, 15 Aug 2024 22:53:12 +0200
Subject: [PATCH] CI: remove unneeded cppcheck premium suppressions (#6702)

---
 .github/workflows/cppcheck-premium.yml |  2 +-
 cppcheckpremium-suppressions           | 15 +++++++++------
 2 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/cppcheck-premium.yml b/.github/workflows/cppcheck-premium.yml
index 0afe6905305..5f5a97e0863 100644
--- a/.github/workflows/cppcheck-premium.yml
+++ b/.github/workflows/cppcheck-premium.yml
@@ -29,7 +29,7 @@ jobs:
         run: |
           premium_version=${{ inputs.premium_version }}
           if [ -z $premium_version ]; then
-            premium_version=devdrop-20240811
+            premium_version=devdrop-20240815
             wget https://files.cppchecksolutions.com/devdrop/cppcheckpremium-$premium_version-amd64.tar.gz -O cppcheckpremium.tar.gz
           else
             wget https://files.cppchecksolutions.com/$premium_version/ubuntu-22.04/cppcheckpremium-$premium_version-amd64.tar.gz -O cppcheckpremium.tar.gz
diff --git a/cppcheckpremium-suppressions b/cppcheckpremium-suppressions
index 2bbbe61e71c..07fce749a80 100644
--- a/cppcheckpremium-suppressions
+++ b/cppcheckpremium-suppressions
@@ -55,13 +55,7 @@ premium-cert-exp55-cpp
 # There are false positives
 premium-misra-cpp-2023-6.5.1:lib/symboldatabase.cpp
 premium-misra-cpp-2023-6.7.2
-premium-misra-cpp-2023-6.8.3
-premium-misra-cpp-2023-7.0.3
-premium-misra-cpp-2023-8.2.5
 premium-misra-cpp-2023-8.18.2
-premium-misra-cpp-2023-13.1.2
-premium-misra-cpp-2023-13.3.1
-premium-misra-cpp-2023-21.6.2
 # False positives: #13004
 premium-misra-cpp-2023-8.2.7:lib/valueflow.cpp
 premium-misra-cpp-2023-8.2.7:lib/checkclass.cpp
@@ -100,6 +94,9 @@ premium-misra-cpp-2023-6.5.2
 # we use local static variables by intention
 premium-misra-cpp-2023-6.7.1
 
+# Could write good warnings but also has a warning about safe code
+premium-misra-cpp-2023-6.8.3
+
 # FIXME enforce proper ref qualifications
 premium-misra-cpp-2023-6.8.4
 
@@ -112,6 +109,9 @@ premium-misra-cpp-2023-7.0.1
 # we convert integer to bool by intention
 premium-misra-cpp-2023-7.0.2
 
+# Misra C++ is too pedantic about using character values
+premium-misra-cpp-2023-7.0.3
+
 # signed integer expression in bitwise rhs by intention
 premium-misra-cpp-2023-7.0.4
 
@@ -247,6 +247,9 @@ premium-misra-cpp-2023-21.2.3
 # Dynamic memory usage in std::string etc
 premium-misra-cpp-2023-21.6.1
 
+# We use new/delete by intention sometimes
+premium-misra-cpp-2023-21.6.2
+
 # TODO use std::make_unique when we require C++14
 premium-misra-cpp-2023-23.11.1