Token: small update_property_info() cleanup (#6601)

danmar · Jul 20, 2024 · 8cce83e · 8cce83e
1 parent 76f1aac
commit 8cce83e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 20 deletions.
diff --git a/lib/token.cpp b/lib/token.cpp
@@ -103,14 +103,19 @@ static const std::unordered_set<std::string> controlFlowKeywords = {
 void Token::update_property_info()
 {
     setFlag(fIsControlFlowKeyword, controlFlowKeywords.find(mStr) != controlFlowKeywords.end());
+    isStandardType(false);
 
     if (!mStr.empty()) {
         if (mStr == "true" || mStr == "false")
             tokType(eBoolean);
-        else if (isStringLiteral(mStr))
+        else if (isStringLiteral(mStr)) {
             tokType(eString);
-        else if (isCharLiteral(mStr))
+            isLong(isPrefixStringCharLiteral(mStr, '"', "L"));
+        }
+        else if (isCharLiteral(mStr)) {
             tokType(eChar);
+            isLong(isPrefixStringCharLiteral(mStr, '\'', "L"));
+        }
         else if (std::isalpha((unsigned char)mStr[0]) || mStr[0] == '_' || mStr[0] == '$') { // Name
             if (mImpl->mVarId)
                 tokType(eVariable);
@@ -157,12 +162,11 @@ void Token::update_property_info()
             tokType(eEllipsis);
         else
             tokType(eOther);
+
+        update_property_isStandardType();
     } else {
         tokType(eNone);
     }
-
-    update_property_char_string_literal();
-    update_property_isStandardType();
 }
 
 static const std::unordered_set<std::string> stdTypes = { "bool"
@@ -180,9 +184,7 @@ static const std::unordered_set<std::string> stdTypes = { "bool"
 
 void Token::update_property_isStandardType()
 {
-    isStandardType(false);
-
-    if (mStr.size() < 3)
+    if (mStr.size() < 3 || mStr.size() > 7)
         return;
 
     if (stdTypes.find(mStr)!=stdTypes.end()) {
@@ -191,15 +193,6 @@ void Token::update_property_isStandardType()
     }
 }
 
-void Token::update_property_char_string_literal()
-{
-    if (mTokType != Token::eString && mTokType != Token::eChar)
-        return;
-
-    isLong(((mTokType == Token::eString) && isPrefixStringCharLiteral(mStr, '"', "L")) ||
-           ((mTokType == Token::eChar) && isPrefixStringCharLiteral(mStr, '\'', "L")));
-}
-
 bool Token::isUpperCaseName() const
 {
     if (!isName())

diff --git a/lib/token.h b/lib/token.h
@@ -1418,9 +1418,6 @@ class CPPCHECKLIB Token {
     /** Update internal property cache about isStandardType() */
     void update_property_isStandardType();
 
-    /** Update internal property cache about string and char literals */
-    void update_property_char_string_literal();
-
     /** Internal helper function to avoid excessive string allocations */
     void astStringVerboseRecursive(std::string& ret, const nonneg int indent1 = 0, const nonneg int indent2 = 0) const;