Fix 11505: FP zerodivcond with modulo

danmar · Jun 25, 2023 · 85fde23 · 85fde23
1 parent 9b892f3
commit 85fde23
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/reverseanalyzer.cpp b/lib/reverseanalyzer.cpp
@@ -225,7 +225,7 @@ struct ReverseTraversal {
                     continue;
                 }
                 // Simple assign
-                if (assignTok->astParent() == assignTop || assignTok == assignTop) {
+                if (assignTok->str() == "=" && (assignTok->astParent() == assignTop || assignTok == assignTop)) {
                     Analyzer::Action rhsAction =
                         analyzer->analyze(assignTok->astOperand2(), Analyzer::Direction::Reverse);
                     Analyzer::Action lhsAction =

diff --git a/test/testother.cpp b/test/testother.cpp
@@ -820,6 +820,14 @@ class TestOther : public TestFixture {
                "    STATIC_ASSERT(sizeof(int) == sizeof(FOO));\n"
                "}\n");
         ASSERT_EQUALS("", errout.str());
+
+        // #11505
+        check("void f(uint16_t num, uint8_t radix) {\n"
+                "    int c = num % radix;\n"
+                "    num /= radix;\n"
+                "    if (!num) {}\n"
+                "}\n");
+        ASSERT_EQUALS("", errout.str());
     }
 
     void nanInArithmeticExpression() {