clang-tidy

danmar · Jun 29, 2024 · 6057a18 · 6057a18
1 parent 828161d
commit 6057a18
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/gui/resultstree.cpp b/gui/resultstree.cpp
@@ -213,7 +213,7 @@ void ResultsTree::keyPressEvent(QKeyEvent *event)
     QTreeView::keyPressEvent(event);
 }
 
-void ResultsTree::setReportType(QString reportType) {
+void ResultsTree::setReportType(const QString& reportType) {
     auto readIdMapping = [this](const std::vector<checkers::IdMapping>& idMapping) {
         for (const auto& i: idMapping)
             for (const QString& cppcheckId: QString(i.cppcheckId).split(","))

diff --git a/gui/resultstree.h b/gui/resultstree.h
@@ -186,7 +186,7 @@ class ResultsTree : public QTreeView {
 
     void keyPressEvent(QKeyEvent *event) override;
 
-    void setReportType(QString reportType);
+    void setReportType(const QString& reportType);
 
     enum class ReportType {normal, autosar, certC, certCpp, misraC, misraCpp2008, misraCpp2023};
 

diff --git a/gui/resultsview.cpp b/gui/resultsview.cpp
@@ -153,8 +153,8 @@ const ShowTypes & ResultsView::getShowTypes() const
     return mUI->mTree->mShowSeverities;
 }
 
-void ResultsView::setReportType(QString name) {
-    mUI->mTree->setReportType(name);
+void ResultsView::setReportType(const QString& reportType) {
+    mUI->mTree->setReportType(reportType);
 }
 
 void ResultsView::progress(int value, const QString& description)

diff --git a/gui/resultsview.h b/gui/resultsview.h
@@ -217,7 +217,7 @@ class ResultsView : public QWidget {
      */
     const ShowTypes & getShowTypes() const;
 
-    void setReportType(QString name);
+    void setReportType(const QString& reportType);
 
 signals: