added TODOs

danmar · May 1, 2024 · 4385cbf · 4385cbf
1 parent d65f697
commit 4385cbf
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 4 deletions.
diff --git a/lib/settings.h b/lib/settings.h
@@ -382,6 +382,7 @@ class CPPCHECKLIB WARN_UNUSED Settings {
     /** @brief forced includes given by the user */
     std::list<std::string> userIncludes;
 
+    // TODO: adjust all options so 0 means "disabled" and -1 "means "unlimited"
     struct ValueFlowOptions
     {
         /** @brief Control if ValueFlow is performed in Tokenizer::simplifyTokens1() */

diff --git a/lib/valueflow.cpp b/lib/valueflow.cpp
@@ -1161,8 +1161,10 @@ static size_t bitCeil(size_t x)
 
 static size_t getAlignOf(const ValueType& vt, const Settings& settings, int maxRecursion = 0)
 {
-    if (maxRecursion == settings.vfOptions.maxAlignOfRecursion)
+    if (maxRecursion == settings.vfOptions.maxAlignOfRecursion) {
+        // TODO: add bailout message
         return 0;
+    }
     if (vt.pointer || vt.reference != Reference::None || vt.isPrimitive()) {
         auto align = ValueFlow::getSizeOf(vt, settings);
         return align == 0 ? 0 : bitCeil(align);
@@ -1196,8 +1198,10 @@ static nonneg int getSizeOfType(const Token *typeTok, const Settings &settings)
 
 size_t ValueFlow::getSizeOf(const ValueType &vt, const Settings &settings, int maxRecursion)
 {
-    if (maxRecursion == settings.vfOptions.maxSizeOfRecursion)
+    if (maxRecursion == settings.vfOptions.maxSizeOfRecursion) {
+        // TODO: add bailout message
         return 0;
+    }
     if (vt.pointer || vt.reference != Reference::None)
         return settings.platform.sizeof_pointer;
     if (vt.type == ValueType::Type::BOOL || vt.type == ValueType::Type::CHAR)
@@ -3294,8 +3298,10 @@ struct ExpressionAnalyzer : SingleValueFlowAnalyzer {
     }
 
     void setupExprVarIds(const Token* start, int depth = 0) {
-        if (depth > settings.vfOptions.maxExprVarIdDepth)
+        if (depth > settings.vfOptions.maxExprVarIdDepth) {
+            // TODO: add bailout message
             return;
+        }
         visitAstNodes(start, [&](const Token* tok) {
             const bool top = depth == 0 && tok == start;
             const bool ispointer = astIsPointer(tok) || astIsSmartPointer(tok) || astIsIterator(tok);
@@ -7189,6 +7195,7 @@ static bool valueFlowForLoop2(const Token *tok,
         if (!error)
             execute(secondExpression, programMemory, &result, &error, settings);
     }
+    // TODO: add bailout message
 
     if (memory1)
         memory1->swap(startMemory);
@@ -7598,6 +7605,7 @@ static bool productParams(const Settings& settings, const std::unordered_map<Key
     if (args.size() > max) {
         bail = true;
         args.resize(max);
+        // TODO: add bailout message
     }
 
     for (const auto& arg:args) {
@@ -9488,8 +9496,10 @@ struct ValueFlowPassRunner {
     bool run(const ValuePtr<ValueFlowPass>& pass) const
     {
         auto start = Clock::now();
-        if (start > stop)
+        if (start > stop) {
+            // TODO: add bailout message
             return true;
+        }
         if (!state.tokenlist.isCPP() && pass->cpp())
             return false;
         if (timerResults) {