From 269e5ce82e8195532212f42ea5543e5c03609ef9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Marjam=C3=A4ki?= <daniel.marjamaki@gmail.com>
Date: Thu, 20 Jun 2024 16:21:59 +0200
Subject: [PATCH] Fixed #12862 (std.cfg: std::is.. functions returns bool)

---
 cfg/std.cfg      | 74 ++++++++++++++++++++++++++++++++++++++++--------
 test/cfg/std.cpp | 28 +++++++++++++++++-
 2 files changed, 89 insertions(+), 13 deletions(-)

diff --git a/cfg/std.cfg b/cfg/std.cfg
index 774e4dbf1c7d..8af76755bb35 100644
--- a/cfg/std.cfg
+++ b/cfg/std.cfg
@@ -3318,11 +3318,7 @@ The obsolete function 'gets' is called. With 'gets' you'll get a buffer overrun
     </arg>
   </function>
   <!-- int isfinite(double x); -->
-  <!-- bool isfinite(float x); // since C++11 -->
-  <!-- bool isfinite(double x); // since C++11 -->
-  <!-- bool isfinite(long double x); // since C++11 -->
-  <!-- bool isfinite(Integral x); // since C++11 -->
-  <function name="isfinite,std::isfinite">
+  <function name="isfinite">
     <use-retval/>
     <pure/>
     <returnValue type="int"/>
@@ -3333,8 +3329,23 @@ The obsolete function 'gets' is called. With 'gets' you'll get a buffer overrun
       <not-bool/>
     </arg>
   </function>
+  <!-- bool std::isfinite(float x); // since C++11 -->
+  <!-- bool std::isfinite(double x); // since C++11 -->
+  <!-- bool std::isfinite(long double x); // since C++11 -->
+  <!-- bool std::isfinite(Integral x); // since C++11 -->
+  <function name="std::isfinite">
+    <use-retval/>
+    <pure/>
+    <returnValue type="bool"/>
+    <noreturn>false</noreturn>
+    <leak-ignore/>
+    <arg nr="1" direction="in">
+      <not-uninit/>
+      <not-bool/>
+    </arg>
+  </function>
   <!-- int isgreater(double x, double y); -->
-  <function name="isgreater,std::isgreater">
+  <function name="isgreater">
     <use-retval/>
     <pure/>
     <returnValue type="int">arg1&gt;arg2?1:0</returnValue>
@@ -3347,8 +3358,22 @@ The obsolete function 'gets' is called. With 'gets' you'll get a buffer overrun
       <not-uninit/>
     </arg>
   </function>
+  <!-- bool std::isgreater(double x, double y); -->
+  <function name="std::isgreater">
+    <use-retval/>
+    <pure/>
+    <returnValue type="bool">arg1&gt;arg2?1:0</returnValue>
+    <noreturn>false</noreturn>
+    <leak-ignore/>
+    <arg nr="1" direction="in">
+      <not-uninit/>
+    </arg>
+    <arg nr="2" direction="in">
+      <not-uninit/>
+    </arg>
+  </function>
   <!-- int isgreaterequal(double x, double y); -->
-  <function name="isgreaterequal,std::isgreaterequal">
+  <function name="isgreaterequal">
     <use-retval/>
     <pure/>
     <returnValue type="int">arg1 &gt;= arg2?1:0</returnValue>
@@ -3361,12 +3386,22 @@ The obsolete function 'gets' is called. With 'gets' you'll get a buffer overrun
       <not-uninit/>
     </arg>
   </function>
+  <!-- bool std::isgreaterequal(double x, double y); -->
+  <function name="std::isgreaterequal">
+    <use-retval/>
+    <pure/>
+    <returnValue type="bool">arg1 &gt;= arg2?1:0</returnValue>
+    <noreturn>false</noreturn>
+    <leak-ignore/>
+    <arg nr="1" direction="in">
+      <not-uninit/>
+    </arg>
+    <arg nr="2" direction="in">
+      <not-uninit/>
+    </arg>
+  </function>
   <!-- int isinf(double x); -->
-  <!-- bool isinf(float x); // since C++11 -->
-  <!-- bool isinf(double x); // since C++11 -->
-  <!-- bool isinf(long double x); // since C++11 -->
-  <!-- bool isinf(Integral x); // since C++11 -->
-  <function name="isinf,std::isinf">
+  <function name="isinf">
     <use-retval/>
     <pure/>
     <returnValue type="int"/>
@@ -3377,6 +3412,21 @@ The obsolete function 'gets' is called. With 'gets' you'll get a buffer overrun
       <not-bool/>
     </arg>
   </function>
+  <!-- bool std::isinf(float x); // since C++11 -->
+  <!-- bool std::isinf(double x); // since C++11 -->
+  <!-- bool std::isinf(long double x); // since C++11 -->
+  <!-- bool std::isinf(Integral x); // since C++11 -->
+  <function name="std::isinf">
+    <use-retval/>
+    <pure/>
+    <returnValue type="bool"/>
+    <noreturn>false</noreturn>
+    <leak-ignore/>
+    <arg nr="1" direction="in">
+      <not-uninit/>
+      <not-bool/>
+    </arg>
+  </function>
   <!-- double logb(double x); -->
   <function name="logb,std::logb">
     <use-retval/>
diff --git a/test/cfg/std.cpp b/test/cfg/std.cpp
index 627d2d68bbc7..72df202ac2e5 100644
--- a/test/cfg/std.cpp
+++ b/test/cfg/std.cpp
@@ -2685,6 +2685,13 @@ void uninitvar_fpclassify(void)
     (void)std::fpclassify(ld);
 }
 
+void bool_isfinite(float f)
+{
+    // cppcheck-suppress compareBoolExpressionWithInt
+    // cppcheck-suppress knownConditionTrueFalse
+    if (std::isfinite(f)==123) {}
+}
+
 void uninitvar_isfinite(void)
 {
     float f;
@@ -2700,6 +2707,12 @@ void uninitvar_isfinite(void)
     (void)std::isfinite(ld);
 }
 
+void bool_isgreater(float f)
+{
+    // cppcheck-suppress compareBoolExpressionWithInt
+    if (std::isgreater(f)==123) {}
+}
+
 void uninitvar_isgreater(void)
 {
     float f1,f2;
@@ -2715,6 +2728,12 @@ void uninitvar_isgreater(void)
     (void)std::isgreater(ld1,ld2);
 }
 
+void bool_isgreaterequal(float f)
+{
+    // cppcheck-suppress compareBoolExpressionWithInt
+    if (std::isgreaterequal(f)==123) {}
+}
+
 void uninitvar_isgreaterequal(void)
 {
     float f1,f2;
@@ -2730,6 +2749,13 @@ void uninitvar_isgreaterequal(void)
     (void)std::isgreaterequal(ld1,ld2);
 }
 
+void bool_isinf(float f)
+{
+    // cppcheck-suppress compareBoolExpressionWithInt
+    // cppcheck-suppress knownConditionTrueFalse
+    if (std::isinf(f)==123) {}
+}
+
 void uninitvar_isinf(void)
 {
     double d;
@@ -5085,4 +5111,4 @@ void constParameterReference_assign(std::vector<int>& v, int& r) {
 void constParameterReference_insert(std::list<int>& l, int& r) {
     l.insert(l.end(), r);
     l.insert(l.end(), 5, r);
-}
\ No newline at end of file
+}