Skip to content
This repository has been archived by the owner on Nov 14, 2020. It is now read-only.

SentryModule.forRoot does not allow any dynamic configuration #8

Open
jeremypele opened this issue Jan 11, 2018 · 0 comments · May be fixed by #33
Open

SentryModule.forRoot does not allow any dynamic configuration #8

jeremypele opened this issue Jan 11, 2018 · 0 comments · May be fixed by #33

Comments

@jeremypele
Copy link
Contributor

For angular aot requirements, a direct string would work correctly
e.g => SentryModule.forRoot({ dsn: 'abc123' }),

but any const, function, getter would break the instanciation
e.g => SentryModule.forRoot({ dsn: AppConfig.sentryDSN }),

Would be cool to have something like TranslateModule for instance where you can provide a factory

TranslateModule.forRoot({
      loader: {
        provide: TranslateLoader,
        useFactory: translateLoaderFactory,
        deps: [Http],
      },
    }),
@NickSch1 NickSch1 linked a pull request Jul 4, 2019 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant