Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Think about the layer abstraction. #16

Open
dalejung opened this issue Jul 27, 2013 · 0 comments
Open

Think about the layer abstraction. #16

dalejung opened this issue Jul 27, 2013 · 0 comments

Comments

@dalejung
Copy link
Owner

Right now we have:

Layer.data(df).geom(Line()).geom(Rect())

and

Line().data(df).view()

So Layers are in reality both data and chart builders. In the first example, Layer() is being used to hold data, and Line/Rect are only used for their chart builder. Layer passes its data to the chart builders.

However, in the second example Line().data(df) is a full Layer and then we create a view of of it.

Maybe I'm overthinking this, but Layer seems to be overloaded? Though to be fair, in the first example, Line and Rect do end up being full layers. So maybe I just think it's confusing that a Layer can be a Geom when it has no data, or a DataLayer when it has no chart builder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant