Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amicable.sage does not exit cleanly #1

Open
daira opened this issue Apr 25, 2020 · 2 comments
Open

amicable.sage does not exit cleanly #1

daira opened this issue Apr 25, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@daira
Copy link
Owner

daira commented Apr 25, 2020

Eventually all of the worker threads hang, whether or not any acceptable curves are found first. It should exit when it has exhausted the search space.

@daira daira added the bug Something isn't working label Apr 25, 2020
@nathan-at-least
Copy link

If we are selecting the first solution, why not exit after displaying that exact solution?

Wouldn't this complete faster and be less ambiguous?

Do we want to examine other solutions for any reason? If so could we add an --exhaustive | --first set of cli alternatives?

@daira
Copy link
Owner Author

daira commented Dec 15, 2020

When I opened this ticket we did not have a need to pick the first solution. I agree that a --first argument might be useful, and that it would work around the bug in cases where we know there's a solution. It doesn't fix the bug, though; we should exit when we've exhausted the search space regardless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants