Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 BUG: 'Welcome to squad' message isn't populated from mobile notification #1245

Open
1 task done
frank-connolly opened this issue Jun 29, 2024 · 3 comments
Open
1 task done

Comments

@frank-connolly
Copy link

What went wrong? 馃

As a squad admin, when I get a 'someone joined your squad welcome them' notification. On desktop clicking it brings me to comment on welcome post autopopulated with their tag and welcome. On mobile it's blank.

Expected Behavior

Mobile behaviour should match desktop.

Steps to Reproduce Issue

1. Go to 'X joined your squad' notification
2. Click on the notification on desktop and repeat on mobile
3. See the difference in the comment placeholder

Solution Proposed

Review desktop event on notification link. Mirror it on mobile.

Screenshots

![DESCRIPTION](LINK.png)

Environment

No response

Browsers

Chrome

OS

Windows

Version of daily.dev

No response

Additional Context

No response

Code of Conduct

  • I follow the conditions of this project.
@idoshamun
Copy link
Member

Hi @frank-connolly,

Thanks for the report! We'll look into it.

Sidenote: do you find this call to action useful as a squad admin?

@frank-connolly
Copy link
Author

Hi @frank-connolly,

Thanks for the report! We'll look into it.

Sidenote: do you find this call to action useful as a squad admin?

Yes people seem to appreciate a welcome note and I'm not always at my desktop.

@sshanzel
Copy link
Member

sshanzel commented Jul 1, 2024

Thank you for reporting! 馃コ

The issue is most likely within the CommentModal which is used on mobile only. The initialContent from the props is probably not being utilized at the moment. Incorporating it within the component itself should most likely fix the issue. For anyone interested 馃憖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants