-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SymCPD type #70
base: master
Are you sure you want to change the base?
Add SymCPD type #70
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #70 +/- ##
============================================
- Coverage 100.00% 89.11% -10.89%
============================================
Files 13 13
Lines 378 551 +173
============================================
+ Hits 378 491 +113
- Misses 0 60 +60 ☔ View full report in Codecov by Sentry. |
Added struct definition and constructor, as well as ncomps, ndims, size, and getindex functions for the SymCPD type. The way I have it set up currently is with |
Current implementation works sometimes but gets a message from LBFGSB about the line search failing sometimes. Need to check the implementation of the gradients.
|
Adding Symmetric CPD (SymCPD) type to support symmetric generalized CP decompositions in the future.