Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowlist for private IPs #157

Open
HelgeKrueger opened this issue Oct 28, 2024 · 1 comment
Open

Allowlist for private IPs #157

HelgeKrueger opened this issue Oct 28, 2024 · 1 comment

Comments

@HelgeKrueger
Copy link

For testing/development purposes, one needs to be able to allowlist private IP addresses. Such an allowlist is better practice than the current simple yes/no choice.

For implementers:
dahlia/hollo#53 (comment)

and the entire discussion therein for background.

@ThisIsMissEm
Copy link
Contributor

The only complexity I foresee here is that we're not using a package for IP address handling, but actually some inlined code (this concerns me a bit)

As such we don't have easy functionality to test ranges against IP addresses

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants