Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio stops on Xrun #71

Open
nchouba opened this issue Nov 11, 2024 · 2 comments
Open

Audio stops on Xrun #71

nchouba opened this issue Nov 11, 2024 · 2 comments
Assignees
Milestone

Comments

@nchouba
Copy link

nchouba commented Nov 11, 2024

Hi,
Setup:

  • Jack: 512 samples /48K
  • Realtime Kernel
  • Rasperry pi 5 (bookworm through patchbox os)
  • Digitak II

whenever I get an Xrun the audio stops. is this expected? is the same happens with other Elektron devices?
ovw logs:
Digitakt II @ 003,002: o2h latency: 16.0 [10.7, 19.4] ms; h2o latency: -1.0 [-1.0, -1.0] ms, o2h ratio: 0.999727 Digitakt II @ 003,002: o2h latency: 15.7 [10.7, 19.4] ms; h2o latency: -1.0 [-1.0, -1.0] ms, o2h ratio: 0.999670 ERROR:jclient.c:56:jclient_thread_xrun_cb: JACK xrun ERROR:resampler.c:448:ow_resampler_compute_ratios: Skipping DLL update (xrun)... ERROR:resampler.c:300:ow_resampler_read_audio: Forcing o2h read (xrun)... Digitakt II @ 003,002: o2h latency: 15.4 [10.7, 18.2] ms; h2o latency: -1.0 [-1.0, -1.0] ms, o2h ratio: 0.999879 Digitakt II @ 003,002: o2h latency: 15.5 [10.7, 18.2] ms; h2o latency: -1.0 [-1.0, -1.0] ms, o2h ratio: 0.999891 Digitakt II @ 003,002: o2h latency: 15.6 [10.7, 18.2] ms; h2o latency: -1.0 [-1.0, -1.0] ms, o2h ratio: 0.999890
Thanks a lot.

@dagargo
Copy link
Owner

dagargo commented Nov 11, 2024

Occasionally, this happens to me too.

I recently added code to improve xrun handling. Perhaps the issue is there. I'll check this.

As a side note and If you don't know, using triple backtics enables code blocks in Markdown. This makes logs much easier to read.

@dagargo dagargo self-assigned this Nov 12, 2024
@dagargo dagargo added this to the 2.0 milestone Nov 12, 2024
@dagargo
Copy link
Owner

dagargo commented Nov 13, 2024

As I suspected, the error was happening in the code to handle xruns. I've fixed it in 7e89555.

However, the xrun handling code to correct the latencies and the DLL calculations is not needed after all since there are no skipped cycles and everything will fix itself after a few cycles. So I have removed all this code in b03f469.

Also, I've fixed and improved the max latencies calculations so that now they are reset when changes in the graph happen as this sometimes leads to temporary increases in the buffer usage, and therefore max latency.

@nchouba, could you try again and report back?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants