Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appcleaner takes almost 30 minutes to finish it's job with root privilege while with shizuku takes a few seconds. #1443

Open
raihan-emon opened this issue Oct 28, 2024 · 3 comments
Labels
c: AppCleaner c: IO SAF/Normal/Root access Root

Comments

@raihan-emon
Copy link

Describe the bug
Well, the title said pretty much everything.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Smartphone (please complete the following information):

  • Device: [Poco M4 Pro 5G]
  • OS: [Android 13]
  • Root status [Rooted - Magisk v28]
  • SD Maid 2/SE version [1.2.8-rc0]

Debug log
If you can reproduce the bug, record the event in a debug log.

Screenshots/Video
If applicable, add screenshots or a video if it helps to explain your problem.

Additional context
Add any other context about the problem here.

@raihan-emon raihan-emon added bug Something isn't working as expected triage This ticket needs to be sorted and labeled. labels Oct 28, 2024
@d4rken d4rken added needs info/repro 🤔 Needs more information (from OP?) to be acted upon c: AppCleaner and removed triage This ticket needs to be sorted and labeled. labels Oct 28, 2024
@d4rken
Copy link
Member

d4rken commented Oct 28, 2024

Please provide a debug log

@raihan-emon
Copy link
Author

Sorry for the late, here's the log.
eu.darken.sdmse_logfile_1730345375237.zip

@d4rken d4rken added c: IO SAF/Normal/Root access Root and removed bug Something isn't working as expected needs info/repro 🤔 Needs more information (from OP?) to be acted upon labels Nov 4, 2024
@d4rken
Copy link
Member

d4rken commented Nov 4, 2024

Almost 30min being 19min here 😉, but i agree that it is somewhat slow.

For 2000 files from Chrome it took from 39:25 to 41:18, so almost 2min.

I'll look into speeding this up.

Most time is spend within the deletion routine here:

suspend fun deleteAll(
targets: Collection<ExpendablesFilter.Match.Deletion>,
gatewaySwitch: GatewaySwitch,
allMatches: Collection<ExpendablesFilter.Match>,
): ExpendablesFilter.ProcessResult {

Not sure yet if the logic there is the issue (maybe could make it more efficient) or if the back and forth between root-nonroot process consumes too much time (could look into batching operations).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: AppCleaner c: IO SAF/Normal/Root access Root
Projects
None yet
Development

No branches or pull requests

2 participants