-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionally use rustls instead of hyper-tls #57
Comments
You can use the vendored OpenSSL. E.g., https://github.com/d-e-s-o/apcacli/blob/main/.github/workflows/build.yml Edit: Though I suppose it's using a cross compiler, so perhaps not what you want. Not sure why using one would not be recommended? (and by whom?)
I think it may be useful, yeah; feel free to contribute it back. |
I added a One more thing: I needed to change how WebSocket connections are formed. More specifically, I had to manually set TLS configuration settings. |
Will probably have to look at the code. If it's only on one or two code paths it may be fine to use |
I'm interested in this feature too, as my container builds result in:
Adding this line in my Dockerfile fixes things: |
@carlosskii do you intend to open a pull request? |
I'm cross-compiling a bot to
x86_64-unknown-linux-musl
. This crate requireshyper-tls
, which requiresnative-tls
, which uses OpenSSL. The build script for OpenSSL always fails, as it cannot find the proper cross compiler. While I could install a cross-compiler and proceed as normal, this is generally not recommended. Instead, crates can often userustls
instead of OpenSSL, which does not require a cross-compiler.The
hyper
crate says thatrustls
is possible. I'm not 100% sure what specific logic is needed to do this, but not much will change anyway. Thehyper-tls
connector just needs to be swapped with arustls
connector.This would be an opt-in feature, but having a feature flag for this would make cross-compiling and no-dynamic-library builds much easier.
I will be implementing this in a public fork regardless, since I need it for my bot. Would you like it pulled into the main repository when ready?
Thanks!
The text was updated successfully, but these errors were encountered: