Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the sensitivity function to be always at airmass 1.0 #116

Open
cylammarco opened this issue Apr 6, 2023 Discussed in #115 · 0 comments
Open

change the sensitivity function to be always at airmass 1.0 #116

cylammarco opened this issue Apr 6, 2023 Discussed in #115 · 0 comments
Assignees

Comments

@cylammarco
Copy link
Owner

cylammarco commented Apr 6, 2023

Discussed in #115

Originally posted by rjs3273 April 6, 2023
The docs say current dev version of the atmospheric extinction correction only works when provided a science and a standard together. I looked through the code and I think the algorithm is currently moving the science target to the same airmass as the standard observation. That is as opposed to the alternative strategy of moving both to airmass=1 or 0 or any known value. The standard is not modified, only the target. Is that right?

I presume the idea is that atmospheric corrections are rather poorly defined at the best of times so you want to keep the correction applied as small as possible. I can see sense in that.
irrelevent.

This is the second (and independent) source mentioning this issue. I suppose from a data validation point of view, it is far better to compare spectra at airmass 1.0. I will change the workflow for v0.5.X.

@cylammarco cylammarco self-assigned this Apr 6, 2023
@cylammarco cylammarco changed the title Applying atmospheric extinction correction to both science and standard to that at airmass=1.0 change the sensitivity function to be always at airmass 1.0 Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant