Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it safe to enable strictFunctionTypes? #126

Open
weakish opened this issue Mar 16, 2019 · 1 comment
Open

Is it safe to enable strictFunctionTypes? #126

weakish opened this issue Mar 16, 2019 · 1 comment

Comments

@weakish
Copy link

weakish commented Mar 16, 2019

Currently, create-cycle-app turns off strictFunctionTypes checks in .tsconfig in the cycle-scripts-one-fits-all flavor.

"strict": true,
"strictFunctionTypes": false,

I want to know if it is safe to remove the line "strictFunctionTypes": false, from .tsconfig
(strict implies strictFunctionTypes)?
Will this break cycle.js or xstream?

create-cycle-app version: 5.0.0

@jvanbruegge
Copy link
Collaborator

Sorry that I answer this now, kinda missed the notification. It should be save to remove that line, as I recently updated Cycle.js to support the complete strict mode. But please let me know if it really worked!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants