-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for pnpm #110
Comments
So you suggest to run yarn first and then pnpm? pnpm will move folders created by yarn into Regarding the error, I don't know what can be the reason, I need to have a deeper look into it. |
@zkochan Thanks for taking a look. By default it runs npm to install. And I found when I then run Re the error. I rummaged around but got lost. However a better solution is to use the I'll leave this open for others to comment on adding pnpm support. I'd like to use it. I know @staltz has been using it for his work and also likes it. |
Closing as the advantage of pnpn is it links to a local cache of packages and latest npm does the same. |
No, npm does not link from the cache. And unlikely will. It copies packages from the cache, like Yarn |
I had discussions about this with the npm team. They are not planning to support linking from the cache |
@zkochan Ah, I was told it does! Thanks for correction. |
As a temporary fix for this, I suggest adding a |
pnpm is looking pretty solid now and is fast as it links to modules in a cach.
At some point it would be good it create-cycle-app supported it. However I found a couple of problems
Add option for pnpm
Currently the CLI and
/src/installScripts.js
supports npm or optionally yarnHowever it appears you can run
pnmp install
later and to adjust the npm node_modules layoutScript resolution fails
eg
https://github.com/cyclejs-community/create-cycle-app-flavors/blob/master/packages/cycle-scripts-one-fits-all/index.js#L15
Does not find the script in my case the resolution for
start
wasC:\projects\pnpmtest\my-app\node_modules\.registry.npmjs.org\cycle-scripts-one-fits-all\2.0.0\node_modules\cycle-scripts-one-fits-all\scripts\start.js
That might be an problem with pnpm or else a problem with running pnpm install on a npm installation
The text was updated successfully, but these errors were encountered: