[CCA-Diversity] Move init questions to cycle-scripts

[jvanbruegge]

To keep things related to the flavor in the flavor and not in create-cycle-app
@nickbalestra

[nickbalestra]

I think is fair to have a better upfront DX with the core-flavor as there is already a light coupling with the CLi and the core-flavor (cycle-scripts)
For custom flavors yes.
btw cycle-scripts support both.

[jvanbruegge]

would it change something? AFAIK, the questions would only be moved to the init.js

[nickbalestra]

Is already there. You mean removing it from the create-cycle-app?

[jvanbruegge]

I mean this file, if this shouldnt be in the cycle-scripts

[nickbalestra]

as in this ?

[jvanbruegge]

yes ^^, so you just have to delete the other file?

[nickbalestra]

You would also want to remove the check logic if you want to do this.

I was thinking of the guy who doesn't read docs (as everybody) just install and run the CLI, asking upfront will make it self-understandable of what is going to happen next, then braking the flow into the middle of various installs. But I could be wrong ofc.

[jvanbruegge]

I dont think it matters if there is a small waiting period. You run cca without argumets, it downloads the cycle-scripts and then asks you what language and stream lib you want to use. Normal people usually wait if there is a progress bar indicating the program is doing something :)

[nickbalestra]

I'm fine with either ways... Though I think is important to advertise this change to people upfront. Now people don't expect any question therefore the fact that the core flavor now supports multiple languages and stream library should be promoted "upfront". Afterward is not a big deal so we could definitely think of removing from cca

[jvanbruegge]

this has a massive downfall for us, we cant test locally. If you use the --flavor options the app throws an error, because options is not defined in setup.js

[nickbalestra]

That's why you need to handle it on both side. For testing this you can use the --forceprompt flag. Left you an example on the PR. I'll plan to add integration tests for it on the cca, but we should also add unit and integration tests for the flavor as well.

[jvanbruegge]

Well not neccesary on both sides. Flavor side alone is enough :)

[nickbalestra]

Diversity release will focus on enable diversity. The prompt will be only on stream lib (xstream, rxjs, most) and such diversity API will be in charge of pass this information to the flavor.

I suggest that as the CCA will be diversity, that prompt (streamLib) will be the only prompt at CCA level (not cycle-scripts). A flag to mute should be added.
Every other prompt is due to to flavor duties.