Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow the new upstream policy to treat klog flags in controllers #2320

Open
4 tasks
yokaze opened this issue Jun 29, 2023 · 0 comments
Open
4 tasks

Follow the new upstream policy to treat klog flags in controllers #2320

yokaze opened this issue Jun 29, 2023 · 0 comments
Labels
KAIZEN Improve our life

Comments

@yokaze
Copy link
Contributor

yokaze commented Jun 29, 2023

What

The k8s upstream decided to change what klog flags to expose.
https://github.com/kubernetes/enhancements/blob/master/keps/sig-instrumentation/2845-deprecate-klog-specific-flags-in-k8s-components/README.md#removed-klog-flags

It looks better to follow the upstream policy. For example, --logtostderr flag appears in: neco-admission, cadvisor, kube-storage-version-migrator, accurate, cattage, meows, moco,necotiator, pod-security-admission, and tenet.

How

Read KEP 2845 and remove all the deprecated flags from our controllers and container images.

Checklist

  • Finish implementation of the issue
  • Test all functions
  • Have enough logs to trace activities
  • Notify developers of necessary actions
@yokaze yokaze added the KAIZEN Improve our life label Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
KAIZEN Improve our life
Projects
None yet
Development

No branches or pull requests

1 participant