Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement short vs. long configuration on NIRS channels #4

Open
cyberjunk opened this issue Oct 16, 2024 · 0 comments
Open

Implement short vs. long configuration on NIRS channels #4

cyberjunk opened this issue Oct 16, 2024 · 0 comments
Assignees

Comments

@cyberjunk
Copy link
Owner

cyberjunk commented Oct 16, 2024

Add support for short vs. long setting on NIRS device channels.
Without breaking other device types or other NIRS models.

(1) UI - Two options
(a) Add a checkbox column (Short: Yes/No) to existing channel selection window:

  • Hide the column if not applicable (e.g. not a NIRS device or not supported by device)
  • This could be confusing because it will affect 4 LSL channels (4 entries in that list) simultaneously. Flipping it on one entry needs to also flip it on all others that belong to the same device channel (same devch value in the device json).

(b) Add a dedicated UI to configure it

  • This should show a list with one entry per device channel (instead of one entry per LSL channel)

(2) Protocols/Internal
Instead of accessing a certain channel group by e.g. window.HbO inside the protocol (e.g. here), one should be able to write window.HbO.Long or window.HbO.Short to access all selected long and short HbO channels. This will also need adjustements in the requires() part, for instance something like r.channels(1).short = true|false and at several other places in the code...

@aeldably aeldably self-assigned this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants