Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests automate fetching version from values.yml instead of hardcoding it #270

Open
2 tasks
izgeri opened this issue Nov 30, 2020 · 0 comments
Open
2 tasks

Tests automate fetching version from values.yml instead of hardcoding it #270

izgeri opened this issue Nov 30, 2020 · 0 comments
Labels
component/k8s kind/technical-debt

Comments

@izgeri
Copy link
Contributor

izgeri commented Nov 30, 2020

At current, the test case in deploy/test/test_cases/TEST_ID_22_helm_rbac_defaults_taken_successfully.sh hardcodes the version, and this test fails on version bumps unless you also update the hardcoded value in the test.

AC:

  • Update the test to remove the hardcoded value and automate retrieving the proper value
  • Update the CONTRIBUTING guide reference to updating this file on version bumps, since with this change that would no longer be needed

See also: #268 for a build that failed on this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/k8s kind/technical-debt
Milestone
No milestone
Development

No branches or pull requests
1 participant
@izgeri