Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow deployment of stable Conjur version #214

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Allow deployment of stable Conjur version #214

wants to merge 2 commits into from

Conversation

john-odonnell
Copy link
Contributor

@john-odonnell john-odonnell commented Dec 10, 2021 •
edited
Loading

Desired Outcome

Scripts for testing and examples should be able to run against the latest stable version of Conjur.
Scripts run against cyberark/conjur:edge for its advantages:

  • bug discovery of unreleased changes in the Conjur server
  • ensure that the OpenAPI description is kept in-phase with the server

Users that aren't actively developing the project should be able to run these tests/examples without
being made aware of possible bugs.

Implemented Changes

  • bin/start_conjur can be configured in two ways:
    • --stable flag (prioritized)
    • global environment variable CONJUR_OPEN_SOURCE_IMAGE_TAG
  • Scripts that call bin/start_conjur use either of the above methods
  • util function ensure_conjur_up also ensures that a deployed version of Conjur is of the desired tag
  • Examples always run against that latest stable version
  • bin/test_integration and bin/test_api_contract scripts can be called with the --stable flag, but default to using Conjur's edge version
  • CI pipelines run against cyberark/conjur:edge to maintain the advantages listed above.

Connected Issue/Story

Resolves #213

CyberArk internal issue link: N/A

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@john-odonnell john-odonnell self-assigned this Dec 10, 2021
@john-odonnell
Small bug fixes
d018bd2 
- Redirect stdout to /dev/null during client gen
- Update command for colorful announce messages
- Address deprecation warning in docker-compose network declaration
@john-odonnell
Allow deployment of stable Conjur version
bf41c9f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@john-odonnell john-odonnell

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow scripts to deploy Conjur either as latest or edge versions
1 participant
@john-odonnell