Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automated tests exist and are run by a Jenkins build job #3

Open
apotterri opened this issue Dec 20, 2018 · 1 comment
Open

automated tests exist and are run by a Jenkins build job #3

apotterri opened this issue Dec 20, 2018 · 1 comment

Comments

@apotterri
Copy link

To demonstrate that the code functions as expected, and to prevent future regressions, there should be a suite of automated test for the plugin. src/test/java/org/conjur/jenkins/configuration/ConjurConfigurationTest.java exists, but the body of the test method is commented out.

As part of writing the test suite, a Jenkinsfile should be added that runs the suite and builds the .hpi when the tests all pass.

@AndrewCopeland
Copy link
Contributor

We do have E2E tests within a separate private repo.
However I do agree that more effort regarding unit tests will most likely improve quality.

I think this issue should be remain open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants