Refactoring, DEV-219

customgento · Nov 30, 2023 · 0ef15fa · 0ef15fa
1 parent af83827
commit 0ef15fa
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 20 deletions.
diff --git a/Test/Integration/AddScriptTest.php b/Test/Integration/AddScriptTest.php
@@ -23,55 +23,43 @@ protected function setUp(): void
     /**
      * @magentoConfigFixture current_store web/cookiebot/enabled 1
      * @magentoConfigFixture current_store cookiebot/id 123-456-789
-     * @magentoConfigFixture current_store web/cookiebot/use_eu_cdn 1
      */
     public function testScriptAddedOnHomepage(): void
     {
         $this->dispatch('/');
         self::assertStringContainsString($this->script, $this->getResponse()->getBody());
-        self::assertEquals('<script id="Cookiebot" data-cfasync="false" src="https://consent.cookiebot.eu/uc.js" data-cbid=""  type="text/javascript" async></script>',
-            $this->script);
     }
 
     /**
-     * @magentoApiDataFixture   Magento/Catalog/_files/product_simple.php
+     * @magentoDataFixture   Magento/Catalog/_files/product_simple.php
      * @magentoConfigFixture current_store web/cookiebot/enabled 1
      * @magentoConfigFixture current_store web/cookiebot/id 123-456-789
-     * @magentoConfigFixture current_store web/cookiebot/use_eu_cdn 0
      */
     public function testScriptAddedOnProductPage(): void
     {
         $this->dispatch('/catalog/product/view/id/1');
         self::assertStringContainsString($this->script, $this->getResponse()->getBody());
-        self::assertEquals('<script id="Cookiebot" data-cfasync="false" src="https://consent.cookiebot.com/uc.js" data-cbid="123-456-789"  type="text/javascript" async></script>',
-            $this->script);
     }
 
     /**
      * @magentoDataFixture   Magento/Catalog/_files/category.php
      * @magentoConfigFixture current_store web/cookiebot/enabled 1
      * @magentoConfigFixture current_store web/cookiebot/id 123-456-789
-     * @magentoConfigFixture current_store web/cookiebot/use_eu_cdn 1
      */
     public function testScriptAddedOnCategoryPage(): void
     {
         $this->dispatch('/catalog/category/view/id/333');
         self::assertStringContainsString($this->script, $this->getResponse()->getBody());
-        self::assertEquals('<script id="Cookiebot" data-cfasync="false" src="https://consent.cookiebot.eu/uc.js" data-cbid="123-456-789"  type="text/javascript" async></script>',
-            $this->script);
     }
 
     /**
      * @magentoDataFixture   Magento/Cms/_files/pages.php
      * @magentoConfigFixture current_store web/cookiebot/enabled 1
      * @magentoConfigFixture current_store web/cookiebot/id 123-456-789
-     * @magentoConfigFixture current_store web/cookiebot/use_eu_cdn 1
      */
     public function testScriptAddedOnCmsPage(): void
     {
         $this->dispatch('/page100');
         self::assertStringContainsString($this->script, $this->getResponse()->getBody());
-        self::assertEquals('<script id="Cookiebot" data-cfasync="false" src="https://consent.cookiebot.eu/uc.js" data-cbid="123-456-789"  type="text/javascript" async></script>',
-            $this->script);
     }
 }
diff --git a/Test/Integration/Model/ConfigTest.php b/Test/Integration/Model/ConfigTest.php
@@ -74,5 +74,4 @@ public function testIfEuCdnEnabledConfigFunctionReturnsTrue(): void
     {
         self::assertTrue($this->config->useEuCdn());
     }
-
 }
diff --git a/Test/Integration/Model/ScriptGeneratorTest.php b/Test/Integration/Model/ScriptGeneratorTest.php
@@ -26,20 +26,18 @@ protected function setUp(): void
     /**
      * @magentoConfigFixture current_store web/cookiebot/use_eu_cdn 0
      */
-    public function testWhenUseEuCdnIsDisabled(): void
+    public function testDomainWhenUseEuCdnIsDisabled(): void
     {
         $generatedScript = ObjectManager::getInstance()->create(ScriptGenerator::class)->generate();
-        self::assertStringContainsString('https://consent.cookiebot.com/uc.js',
-            $generatedScript);
+        self::assertStringContainsString('https://consent.cookiebot.com/uc.js', $generatedScript);
     }
 
     /**
      * @magentoConfigFixture current_store web/cookiebot/use_eu_cdn 1
      */
-    public function testWhenUseEuCdnIsEnabled(): void
+    public function testDomainWhenUseEuCdnIsEnabled(): void
     {
         $generatedScript = ObjectManager::getInstance()->create(ScriptGenerator::class)->generate();
-        self::assertStringContainsString('https://consent.cookiebot.eu/uc.js',
-            $generatedScript);
+        self::assertStringContainsString('https://consent.cookiebot.eu/uc.js', $generatedScript);
     }
 }
-Original file line number
+Diff line change
@@ Expand Up @@
         {
             self::assertTrue($this->config->useEuCdn());
         }
     }