Discussion about Pyright for Static Type Checking in CI / Locally #2266

C-Loftus · 2024-03-18T16:49:49Z

C-Loftus
Mar 18, 2024

Discussed with Pokey at Cursorless meetup last weekend about Pyright CI. Posting this here as a discussion to evaluate if Pyright is useful for Cursorless in its CI pipeline. Wanted to align at a high level about preferences before creating any PRs.

Upside for Pyright integration

Talon can't be installed or ran in CI but it still makes sense to try and test as much as possible
Pyright provides good static type checking and sanity checks for Python.
Pyright is integrated with Python vscode extensions already (via Pylance to my understanding) but could help in CI so everyone has the same config
Pyright can be configured in the pyproject.toml

Downside for Pyright integration

Since we can't install Talon in CI, we essentially have to ignore all Talon typing and imports unless we import typing stubs or something analogous

c:\Users\cloftus\github\cursorless\cursorless-talon\src\cheatsheet\cheat_sheet.py:4:6 - error: Import "talon" could not be resolved (reportMissingImports)

Talon scripting with Python has development patterns that deviate from the norm so we have to ignore some errors similar to the following

c:\Users\cloftus\github\cursorless\cursorless-talon\src\apps\vscode_settings.py:43:14 - error: Type of parameter "key" must be a supertype of its class "Actions" (reportGeneralTypeIssues)

Not entirely sure why you can't get around the "type of parameter X must be a supertype" but since it throws an error you essentially have to disable all reportGeneralTypeIssues to get rid of it.

Pyright Output with Following Config

[tool.pyright]
# Talon classes don't use self so ignore the associated errors
reportSelfClsParameterName = false
# Talon can't be installed in CI so ignore source errors
reportMissingModuleSource = false
reportMissingImports = false

Pyright output with the Following Config (Click me)

PS C:\Users\cloftus\github\cursorless> pyright .
c:\Users\cloftus\github\cursorless\cursorless-talon\src\command.py
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\command.py:31:53 - error: Type of parameter "action" must be a supertype of its class "Actions" (reportGeneralTypeIssues)
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\command.py:38:52 - error: Type of parameter "action" must be a supertype of its class "Actions" (reportGeneralTypeIssues)
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\command.py:45:48 - error: Type of parameter "action" must be a supertype of its class "Actions" (reportGeneralTypeIssues)
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\command.py:59:28 - error: Object of type "None" is not subscriptable (reportOptionalSubscript)
c:\Users\cloftus\github\cursorless\cursorless-talon\src\cursorless_command_server.py
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\cursorless_command_server.py:11:21 - error: Type of parameter "command_id" must be a supertype of its class "Actions" (reportGeneralTypeIssues)
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\cursorless_command_server.py:20:21 - error: Type of parameter "command_id" must be a supertype of its class "Actions" (reportGeneralTypeIssues)
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\cursorless_command_server.py:29:21 - error: Type of parameter "command_id" must be a supertype of its class "Actions" (reportGeneralTypeIssues)
c:\Users\cloftus\github\cursorless\cursorless-talon\src\scope_visualizer.py
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\scope_visualizer.py:15:21 - error: Type of parameter "scope_type" must be a supertype of its class "Actions" (reportGeneralTypeIssues)
c:\Users\cloftus\github\cursorless\cursorless-talon\src\snippets.py
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\snippets.py:89:9 - error: Argument of type "dict[Unknown, Unknown]" cannot be assigned to parameter "__value" of type "str" in function "__setitem__"
    "dict[Unknown, Unknown]" is incompatible with "str" (reportArgumentType)
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\snippets.py:104:9 - error: Argument of type "list[dict[Unknown, Unknown]]" cannot be assigned to parameter "__value" of type "str" in function "__setitem__"
    "list[dict[Unknown, Unknown]]" is incompatible with "str" (reportArgumentType)
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\snippets.py:111:62 - error: Type of parameter "insertion_snippet" must be a supertype of its class "Actions" (reportGeneralTypeIssues)
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\snippets.py:119:30 - error: Type of parameter "snippet_description" must be a supertype of its class "Actions" (reportGeneralTypeIssues)
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\snippets.py:129:49 - error: Type of parameter "name" must be a supertype of its class "Actions" (reportGeneralTypeIssues)
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\snippets.py:137:15 - error: Type of parameter "body" must be a supertype of its class "Actions" (reportGeneralTypeIssues)
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\snippets.py:150:37 - error: Argument of type "CursorlessDestination | None" cannot be assigned to parameter "destination" of type "CursorlessDestination" in function "insert_custom_snippet" (reportArgumentType)
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\snippets.py:153:15 - error: Type of parameter "name" must be a supertype of its class "Actions" (reportGeneralTypeIssues)
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\snippets.py:166:15 - error: Type of parameter "body" must be a supertype of its class "Actions" (reportGeneralTypeIssues)
c:\Users\cloftus\github\cursorless\cursorless-talon\src\actions\actions.py
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\actions\actions.py:91:41 - error: Type of parameter "action_name" must be a supertype of its class "Actions" (reportGeneralTypeIssues)
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\actions\actions.py:110:47 - error: Type of parameter "command_id" must be a supertype of its class "Actions" (reportGeneralTypeIssues)
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\actions\actions.py:118:44 - error: Type of parameter "command_id" must be a supertype of its class "Actions" (reportGeneralTypeIssues)
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\actions\actions.py:123:22 - error: Type of parameter "destination" must be a supertype of its class "Actions" (reportGeneralTypeIssues)
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\actions\actions.py:131:22 - error: Type of parameter "instruction" must be a supertype of its class "Actions" (reportGeneralTypeIssues)
c:\Users\cloftus\github\cursorless\cursorless-talon\src\actions\bring_move.py
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\actions\bring_move.py:38:52 - error: Type of parameter "action_name" must be a supertype of its class "Actions" (reportGeneralTypeIssues)
c:\Users\cloftus\github\cursorless\cursorless-talon\src\actions\call.py
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\actions\call.py:12:17 - error: Type of parameter "callee" must be a supertype of its class "Actions" (reportGeneralTypeIssues)
c:\Users\cloftus\github\cursorless\cursorless-talon\src\actions\get_text.py
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\actions\get_text.py:13:17 - error: Type of parameter "target" must be a supertype of its class "Actions" (reportGeneralTypeIssues)
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\actions\get_text.py:24:17 - error: Type of parameter "target" must be a supertype of its class "Actions" (reportGeneralTypeIssues)
c:\Users\cloftus\github\cursorless\cursorless-talon\src\actions\homophones.py
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\actions\homophones.py:18:46 - error: Argument of type "CursorlessTarget" cannot be assigned to parameter "target" of type "ListTarget | RangeTarget | PrimitiveTarget" in function "__init__" (reportArgumentType)
c:\Users\cloftus\github\cursorless\cursorless-talon\src\actions\paste.py
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\actions\paste.py:12:47 - error: Type of parameter "destination" must be a supertype of its class "Actions" (reportGeneralTypeIssues)
c:\Users\cloftus\github\cursorless\cursorless-talon\src\actions\reformat.py
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\actions\reformat.py:14:45 - error: Type of parameter "target" must be a supertype of its class "Actions" (reportGeneralTypeIssues)
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\actions\reformat.py:18:50 - error: Argument of type "CursorlessTarget" cannot be assigned to parameter "target" of type "ListTarget | RangeTarget | PrimitiveTarget" in function "__init__" (reportArgumentType)
c:\Users\cloftus\github\cursorless\cursorless-talon\src\actions\swap.py
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\actions\swap.py:39:42 - error: Type of parameter "targets" must be a supertype of its class "Actions" (reportGeneralTypeIssues)
c:\Users\cloftus\github\cursorless\cursorless-talon\src\actions\wrap.py
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\actions\wrap.py:13:22 - error: Type of parameter "action_name" must be a supertype of its class "Actions" (reportGeneralTypeIssues)
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\actions\wrap.py:29:22 - error: Type of parameter "action_name" must be a supertype of its class "Actions" (reportGeneralTypeIssues)
c:\Users\cloftus\github\cursorless\cursorless-talon\src\apps\vscode_settings.py
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\apps\vscode_settings.py:29:35 - error: Function with declared return type "Path" must return value on all code paths
    "None" is incompatible with "Path" (reportReturnType)
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\apps\vscode_settings.py:32:33 - error: Type of parameter "key" must be a supertype of its class "Actions" (reportGeneralTypeIssues)
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\apps\vscode_settings.py:43:14 - error: Type of parameter "key" must be a supertype of its class "Actions" (reportGeneralTypeIssues)
c:\Users\cloftus\github\cursorless\cursorless-talon\src\private_api\private_api.py
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\private_api\private_api.py:28:20 - error: Type of parameter "modifiers" must be a supertype of its class "TargetBuilderActions" (reportGeneralTypeIssues)
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\private_api\private_api.py:34:19 - error: Type of parameter "elements" must be a supertype of its class "TargetBuilderActions" (reportGeneralTypeIssues)
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\private_api\private_api.py:38:20 - error: Expression of type "PrimitiveTarget | RangeTarget" cannot be assigned to return type "PrimitiveTarget | ListTarget" (reportReturnType)
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\private_api\private_api.py:53:17 - error: Type of parameter "target" must be a supertype of its class "ActionActions" (reportGeneralTypeIssues)
c:\Users\cloftus\github\cursorless\cursorless-talon\src\vendor\jstyleson.py
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\vendor\jstyleson.py:72:32 - error: Argument of type "int | None" cannot be assigned to parameter "__start" of type "SupportsIndex" in function "__new__"
    Type "int | None" cannot be assigned to type "SupportsIndex"
      "None" is incompatible with protocol "SupportsIndex"
        "__index__" is not present (reportArgumentType)
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\vendor\jstyleson.py:93:32 - error: Argument of type "int | None" cannot be assigned to parameter "__start" of type "SupportsIndex" in function "__new__"
    Type "int | None" cannot be assigned to type "SupportsIndex"
      "None" is incompatible with protocol "SupportsIndex"
        "__index__" is not present (reportArgumentType)
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\vendor\jstyleson.py:103:24 - error: Argument of type "int | None" cannot be assigned to parameter "__start" of type "SupportsIndex" in function "__new__"
    Type "int | None" cannot be assigned to type "SupportsIndex"
      "None" is incompatible with protocol "SupportsIndex"
        "__index__" is not present (reportArgumentType)
c:\Users\cloftus\github\cursorless\cursorless-talon-dev\src\spoken_form_test.py
  c:\Users\cloftus\github\cursorless\cursorless-talon-dev\src\spoken_form_test.py:43:21 - error: Type of parameter "command_id" must be a supertype of its class "UserActions" (reportGeneralTypeIssues)
  c:\Users\cloftus\github\cursorless\cursorless-talon-dev\src\spoken_form_test.py:48:21 - error: Type of parameter "command_id" must be a supertype of its class "UserActions" (reportGeneralTypeIssues)
  c:\Users\cloftus\github\cursorless\cursorless-talon-dev\src\spoken_form_test.py:53:21 - error: Type of parameter "command_id" must be a supertype of its class "UserActions" (reportGeneralTypeIssues)
  c:\Users\cloftus\github\cursorless\cursorless-talon-dev\src\spoken_form_test.py:61:58 - error: Type of parameter "enable" must be a supertype of its class "Actions" (reportGeneralTypeIssues)
  c:\Users\cloftus\github\cursorless\cursorless-talon-dev\src\spoken_form_test.py:86:17 - error: Type of parameter "phrase" must be a supertype of its class "Actions" (reportGeneralTypeIssues)
c:\Users\cloftus\github\cursorless\data\playground\python.py
  c:\Users\cloftus\github\cursorless\data\playground\python.py:4:28 - error: Function with declared return type "str" must return value on all code paths
    "None" is incompatible with "str" (reportReturnType)
c:\Users\cloftus\github\cursorless\data\playground\python\maps_and_lists.py
  c:\Users\cloftus\github\cursorless\data\playground\python\maps_and_lists.py:32:10 - error: Dictionary key must be hashable
    Type "dict[str, int]" is not hashable (reportUnhashable)
  c:\Users\cloftus\github\cursorless\data\playground\python\maps_and_lists.py:32:39 - error: Dictionary key must be hashable
    Type "dict[str, int]" is not hashable (reportUnhashable)
  c:\Users\cloftus\github\cursorless\data\playground\python\maps_and_lists.py:33:10 - error: Dictionary key must be hashable
    Type "set[int]" is not hashable (reportUnhashable)
  c:\Users\cloftus\github\cursorless\data\playground\python\maps_and_lists.py:33:24 - error: Dictionary key must be hashable
    Type "set[int]" is not hashable (reportUnhashable)
c:\Users\cloftus\github\cursorless\data\playground\python\statements.py
  c:\Users\cloftus\github\cursorless\data\playground\python\statements.py:16:7 - error: Cannot access member "append" for type "range"
    Member "append" is unknown (reportAttributeAccessIssue)
c:\Users\cloftus\github\cursorless\data\playground\python\values.py
  c:\Users\cloftus\github\cursorless\data\playground\python\values.py:29:1 - error: "Literal[5]" is not iterable
    "__iter__" method not defined (reportGeneralTypeIssues)
  c:\Users\cloftus\github\cursorless\data\playground\python\values.py:29:8 - error: Expression cannot be assignment target
  c:\Users\cloftus\github\cursorless\data\playground\python\values.py:32:5 - error: Function declaration "my_funk" is obscured by a declaration of the same name (reportRedeclaration)
  c:\Users\cloftus\github\cursorless\data\playground\python\values.py:32:28 - error: Function with declared return type "str" must return value on all code paths
    "None" is incompatible with "str" (reportReturnType)
  c:\Users\cloftus\github\cursorless\data\playground\python\values.py:35:57 - error: Function with declared return type "str" must return value on all code paths
    "None" is incompatible with "str" (reportReturnType)
  c:\Users\cloftus\github\cursorless\data\playground\python\values.py:56:6 - error: Dictionary key must be hashable
    Type "dict[str, int]" is not hashable (reportUnhashable)
  c:\Users\cloftus\github\cursorless\data\playground\python\values.py:56:35 - error: Dictionary key must be hashable
    Type "dict[str, int]" is not hashable (reportUnhashable)
  c:\Users\cloftus\github\cursorless\data\playground\python\values.py:57:6 - error: Dictionary key must be hashable
    Type "set[int]" is not hashable (reportUnhashable)
  c:\Users\cloftus\github\cursorless\data\playground\python\values.py:57:20 - error: Dictionary key must be hashable
    Type "set[int]" is not hashable (reportUnhashable)
63 errors, 0 warnings, 0 informations

Pyright Config with a more lenient config

[tool.pyright]
# Talon classes don't use self so ignore the associated errors
reportSelfClsParameterName = false
# Ignore supertype errors
reportGeneralTypeIssues = false
# Imgui functions return an object that can't be statically resolved
reportFunctionMemberAccess = false
# Talon can't be installed in CI so ignore source errors
reportMissingModuleSource = false
reportMissingImports = false

Pyright output with a lenient Config (Click me)

PS C:\Users\cloftus\github\cursorless> pyright .
c:\Users\cloftus\github\cursorless\cursorless-talon\src\command.py
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\command.py:59:28 - error: Object of type "None" is not subscriptable (reportOptionalSubscript)
c:\Users\cloftus\github\cursorless\cursorless-talon\src\snippets.py
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\snippets.py:89:9 - error: Argument of type "dict[Unknown, Unknown]" cannot be assigned to parameter "__value" of type "str" in function "__setitem__"
    "dict[Unknown, Unknown]" is incompatible with "str" (reportArgumentType)
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\snippets.py:104:9 - error: Argument of type "list[dict[Unknown, Unknown]]" cannot be assigned to parameter "__value" of type "str" in function "__setitem__"
    "list[dict[Unknown, Unknown]]" is incompatible with "str" (reportArgumentType)
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\snippets.py:150:37 - error: Argument of type "CursorlessDestination | None" cannot be assigned to parameter "destination" of type "CursorlessDestination" in function "insert_custom_snippet" (reportArgumentType)
c:\Users\cloftus\github\cursorless\cursorless-talon\src\actions\homophones.py
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\actions\homophones.py:18:46 - error: Argument of type "CursorlessTarget" cannot be assigned to parameter "target" of type "ListTarget | RangeTarget | PrimitiveTarget" in function "__init__" (reportArgumentType)
c:\Users\cloftus\github\cursorless\cursorless-talon\src\actions\reformat.py
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\actions\reformat.py:18:50 - error: Argument of type "CursorlessTarget" cannot be assigned to parameter "target" of type "ListTarget | RangeTarget | PrimitiveTarget" in function "__init__" (reportArgumentType)
c:\Users\cloftus\github\cursorless\cursorless-talon\src\apps\vscode_settings.py
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\apps\vscode_settings.py:29:35 - error: Function with declared return type "Path" must return value on all code paths
    "None" is incompatible with "Path" (reportReturnType)
c:\Users\cloftus\github\cursorless\cursorless-talon\src\private_api\private_api.py
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\private_api\private_api.py:38:20 - error: Expression of type "PrimitiveTarget | RangeTarget" cannot be assigned to return type "PrimitiveTarget | ListTarget" (reportReturnType)
c:\Users\cloftus\github\cursorless\cursorless-talon\src\vendor\jstyleson.py
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\vendor\jstyleson.py:72:32 - error: Argument of type "int | None" cannot be assigned to parameter "__start" of type "SupportsIndex" in function "__new__"
    Type "int | None" cannot be assigned to type "SupportsIndex"
      "None" is incompatible with protocol "SupportsIndex"
        "__index__" is not present (reportArgumentType)
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\vendor\jstyleson.py:93:32 - error: Argument of type "int | None" cannot be assigned to parameter "__start" of type "SupportsIndex" in function "__new__"
    Type "int | None" cannot be assigned to type "SupportsIndex"
      "None" is incompatible with protocol "SupportsIndex"
        "__index__" is not present (reportArgumentType)
  c:\Users\cloftus\github\cursorless\cursorless-talon\src\vendor\jstyleson.py:103:24 - error: Argument of type "int | None" cannot be assigned to parameter "__start" of type "SupportsIndex" in function "__new__"
    Type "int | None" cannot be assigned to type "SupportsIndex"
      "None" is incompatible with protocol "SupportsIndex"
        "__index__" is not present (reportArgumentType)
c:\Users\cloftus\github\cursorless\data\playground\python.py
  c:\Users\cloftus\github\cursorless\data\playground\python.py:4:28 - error: Function with declared return type "str" must return value on all code paths
    "None" is incompatible with "str" (reportReturnType)
c:\Users\cloftus\github\cursorless\data\playground\python\maps_and_lists.py
  c:\Users\cloftus\github\cursorless\data\playground\python\maps_and_lists.py:32:10 - error: Dictionary key must be hashable
    Type "dict[str, int]" is not hashable (reportUnhashable)
  c:\Users\cloftus\github\cursorless\data\playground\python\maps_and_lists.py:32:39 - error: Dictionary key must be hashable
    Type "dict[str, int]" is not hashable (reportUnhashable)
  c:\Users\cloftus\github\cursorless\data\playground\python\maps_and_lists.py:33:10 - error: Dictionary key must be hashable
    Type "set[int]" is not hashable (reportUnhashable)
  c:\Users\cloftus\github\cursorless\data\playground\python\maps_and_lists.py:33:24 - error: Dictionary key must be hashable
    Type "set[int]" is not hashable (reportUnhashable)
c:\Users\cloftus\github\cursorless\data\playground\python\statements.py
  c:\Users\cloftus\github\cursorless\data\playground\python\statements.py:16:7 - error: Cannot access member "append" for type "range"
    Member "append" is unknown (reportAttributeAccessIssue)
c:\Users\cloftus\github\cursorless\data\playground\python\values.py
  c:\Users\cloftus\github\cursorless\data\playground\python\values.py:29:8 - error: Expression cannot be assignment target
  c:\Users\cloftus\github\cursorless\data\playground\python\values.py:32:5 - error: Function declaration "my_funk" is obscured by a declaration of the same name (reportRedeclaration)
  c:\Users\cloftus\github\cursorless\data\playground\python\values.py:32:28 - error: Function with declared return type "str" must return value on all code paths
    "None" is incompatible with "str" (reportReturnType)
  c:\Users\cloftus\github\cursorless\data\playground\python\values.py:35:57 - error: Function with declared return type "str" must return value on all code paths
    "None" is incompatible with "str" (reportReturnType)
  c:\Users\cloftus\github\cursorless\data\playground\python\values.py:56:6 - error: Dictionary key must be hashable
    Type "dict[str, int]" is not hashable (reportUnhashable)
  c:\Users\cloftus\github\cursorless\data\playground\python\values.py:56:35 - error: Dictionary key must be hashable
    Type "dict[str, int]" is not hashable (reportUnhashable)
  c:\Users\cloftus\github\cursorless\data\playground\python\values.py:57:6 - error: Dictionary key must be hashable
    Type "set[int]" is not hashable (reportUnhashable)
  c:\Users\cloftus\github\cursorless\data\playground\python\values.py:57:20 - error: Dictionary key must be hashable
    Type "set[int]" is not hashable (reportUnhashable)
25 errors, 0 warnings, 0 informations

pokey · 2024-03-18T17:02:17Z

pokey
Mar 18, 2024
Maintainer

Would you mind opening a draft PR with the lenient config? I think it will be easier to see what's going on that way

Re less lenient config, looks like nearly all of the spurious errors are of the form Type of parameter "XXX" must be a supertype of its class "YYY", due to the way Talon uses classes. I'd argue we should file an issue against pyright to make that error type more fine-grained so that we can exclude it but not all generic type errors

1 reply

C-Loftus Mar 18, 2024
Author

Sounds good, I will do that

C-Loftus · 2024-03-19T14:55:04Z

C-Loftus
Mar 19, 2024
Author

Closing this in favor of the draft PR

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Discussion about Pyright for Static Type Checking in CI / Locally #2266

{{title}}

{{editor}}'s edit

{{editor}}'s edit

Replies: 2 comments 1 reply

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

Select a reply

Discussion about Pyright for Static Type Checking in CI / Locally #2266

C-Loftus Mar 18, 2024

Upside for Pyright integration

Downside for Pyright integration

Pyright Output with Following Config

Pyright Config with a more lenient config

Replies: 2 comments · 1 reply

pokey Mar 18, 2024 Maintainer

C-Loftus Mar 18, 2024 Author

C-Loftus Mar 19, 2024 Author

C-Loftus
Mar 18, 2024

Replies: 2 comments 1 reply

pokey
Mar 18, 2024
Maintainer

C-Loftus Mar 18, 2024
Author

C-Loftus
Mar 19, 2024
Author