Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Player] console output generated by Tests gets properly written into dumps, but won't be shown by Player #76

Open
3 tasks done
BloodyRain2k opened this issue Dec 8, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@BloodyRain2k
Copy link

Before opening, please confirm:

  • I have searched for duplicate or closed issues and discussions.
  • I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
  • I acknowledge that I will attach a full debug log, otherwise the issue will be closed with no response.

Environment information

all the same as #75

Describe the bug

As noted at the end of #75, console output generated by Tests rather than the app/site being tested will be properly written to the dump, but the Player won't render it at all. Even though it is including these logs in the number of the "Console" tab.

I've tried to figure out where it's going wrong, but I've not found the repo for the Player yet, if it even has a public one, and digging through React fibers on the browser end is insanely tedious so I didn't get anywhere yet.

Expected behavior

I am unsure which behavior is "normal", excluding logs generated by Tests or including every log that's "known" and it's just not properly showing them.

But I would expect that the number of entries shown for the "Console" tab would be the actual number of entries it will show me.
So I'd expect that to include the output of Tests too. Maybe it could be marked as such to differentiate.
Maybe even add a selector that allows hiding of Test output or up to which level.

For example: "App: Info, Log, Warn, Error - Test: Warn, Error", but I'm unsure how many other people actually use console logging within tests for troubleshooting.
I mainly did it because I initially only used Open Mode and it was helpful to verify that the Test was actually using the right objects and such.

Command and Setup

all the same as #75

Full log and debug output

N/A because this is an issue with the Player.

@BloodyRain2k BloodyRain2k added the bug Something isn't working label Dec 8, 2023
@agoldis agoldis self-assigned this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants