Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let codegen tool generate multiple files #57

Open
ciaranmcnulty opened this issue Sep 25, 2022 · 2 comments
Open

Let codegen tool generate multiple files #57

ciaranmcnulty opened this issue Sep 25, 2022 · 2 comments

Comments

@ciaranmcnulty
Copy link
Contributor

Both the PHP and Java implementations use csplit to split the generated code across multiple files.

This should be made a feature of codegen.rb in a future refactor

@luke-hill
Copy link
Contributor

I just saw this recently. I am currently refactoring the codegen.rb file completely after having Rien show me how to use csplit on the ruby files to get them all in different ones.

The entire process for using csplit only took around 30-45mins of pairing. I'd be happy to pair up with you if you'd like. I'm not really sure how the codegen could do it, given it loads everything into one big hash / set, and then iterates through them.

We could completely rewrite the codegen.rb logic to do it from first principles I suppose. But that kind of large scale refactor wouldn't be easy to do part-time.

@luke-hill
Copy link
Contributor

#228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants