Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$schema in messages #108

Open
ciaranmcnulty opened this issue Nov 16, 2022 · 3 comments
Open

$schema in messages #108

ciaranmcnulty opened this issue Nov 16, 2022 · 3 comments

Comments

@ciaranmcnulty
Copy link
Contributor

We could start to add $schema URLs to generated JSON

For now this would just suffice to make them more comprehensible/validatable, but going forwards it could allow a schema versioning mechanism

@mpkorstanje
Copy link
Contributor

We'd have to solve a bootstrapping problemen. We don't know what the version of the schema is until we make a release.

And while we could generate all the code when we make a release, we intentionally don't do that to avoid making the build processs complicated.

@mpkorstanje
Copy link
Contributor

Another problem I imagine would be that the messages should be light weight. Adding a url to every envelop is going to increase the size of the ndjson report.

@ciaranmcnulty
Copy link
Contributor Author

It seems to me the schema version could/should be different to the messages version? Or at least we should only increment the schema's major version when we break backwards compatibility in the 'json schema' sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants