Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor issues in the book quickstart #349

Open
robertpateii opened this issue Nov 22, 2024 · 2 comments
Open

Minor issues in the book quickstart #349

robertpateii opened this issue Nov 22, 2024 · 2 comments
Assignees
Labels
bug Something isn't working k::documentation Related to project documentation
Milestone

Comments

@robertpateii
Copy link

Regarding https://cucumber-rs.github.io/cucumber/current/quickstart.html

The path in main for the quickstart guide does not match the instructions given in the text. To fix, quickstart/concurrent and quickstart/simple should both be replaced by animal in the main function code.

Separately, under the Asyncness heading the code does not mention you need to add another use statement like the previous code does. So this should be added to it:
// Don't forget to additionally use tokio::time::{sleep, Duration};

I'll do a PR for this tomorrow.

@tyranron tyranron added bug Something isn't working k::documentation Related to project documentation labels Nov 22, 2024
@tyranron tyranron added this to the 0.22.0 milestone Nov 22, 2024
@tyranron
Copy link
Member

@robertpateii 🙏

@robertpateii
Copy link
Author

@tyranron PR is up. thanks! good quickstart!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working k::documentation Related to project documentation
Projects
None yet
Development

No branches or pull requests

2 participants