Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give proactive information to help fix issues #2

Open
nikitavoloboev opened this issue Feb 1, 2019 · 1 comment
Open

Give proactive information to help fix issues #2

nikitavoloboev opened this issue Feb 1, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@nikitavoloboev
Copy link

Perhaps it would be good if it suggested if the broken link was broken because the file was moved somewhere. And if tool finds the file (same name but different location perhaps) it writes that out as part of the result. I think it would be nice to not have that be default behavior and have it be under a flag as often the user knows himself where the issues are.

Ideally the tool would even proactively suggest to change the links it can 'fix' for the user and have user accept or discard the fixes.

@ctm ctm self-assigned this Feb 1, 2019
@ctm ctm added the enhancement New feature or request label Feb 1, 2019
@ctm
Copy link
Owner

ctm commented Feb 1, 2019

I'll add this feature when I also add support for checking fragments, because I am going to introduce a HashMap that knows about files. I had planned on canonicalizing the file paths and using that as a key, but since there won't be that many duplicated filenames, I can just use the filename as a key and then a Vec of the additional information needed (both for fragments and for suggestions) on a per-file basis.

I'll add line numbers first though, 'cause that should be easier.

@ctm ctm mentioned this issue Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants