Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text interface may have shown incorrect stud cards #1495

Open
ctm opened this issue Sep 6, 2024 · 0 comments
Open

Text interface may have shown incorrect stud cards #1495

ctm opened this issue Sep 6, 2024 · 0 comments
Assignees
Labels
bug Something isn't working can't reproduce Can't reproduce high priority Should be done fairly soon

Comments

@ctm
Copy link
Owner

ctm commented Sep 6, 2024

If this can be reproduced, fix whatever caused GamboMouse to see the wrong cards.

Yesterday evening, a discussion broke out when GamboMouse couldn't believe he was reraised in Razz (Hand #421590). It started with a bet, raise and re-raise on fifth street:

4 🐭GamboMouse 50550 1200 [ ] [ ] Qd Jc 6c
5 B [jpmassar] 65900[ 200]
6 > jrx 55200 1200 [ ] [ ] 4h Js Ts
My cards are: [6d] [9d] 4h Js Ts
It is 0 to you
jrx bets 1600
🐭GamboMouse raises 1600 to 3200
It is 1600 to you
jrx raises 1600 to 4800
🐭GamboMouse: Why?

jrx bet and reraised because he figured his JT4xy was better than GamboMouse's QJ6wz. GamboMouse, OTOH was very surprised, because:

I thought I was showing about 3-J-6. The 6 paired me, but I thought sure JR would fold to my raise.
Instead he 3-bet.

I've already looked at the public and private messages that were sent on this hand, and I don't see anything out of place. However, I can't actually see what GamboMouse saw, and he did have both a 3 and a 6 down.

I have not used the text interface in a long time, nor have I looked at the code for the text interface, nor are many other people using the text interface and on top of that, stud isn't particularly common, so it is possible that there's a bug in the text display of stud upcards, although I can't think of what could cause it.

I am about to disappear for a weekend where I'll be staying in a tent and won't have a lot of battery power, so I probably won't look at it this week. I have some super high priority non-programming work that I need to do (some of which I can do from my tent) and that's going to take precedence over looking at this. However…

I can look to see if there was anything weird logged for GamboMouse's connection and I can check to see if this hand was the first after a break, or the first stud hand after a game switch as well as why the board is labeled as a grid containing now cards (see public messages below). After I do that, if I don't find anything obvious, I'll strip the high priority label because it's the text interface. That's not fair to GamboMouse, but working on the text interface instead of doing other things isn't fair to pretty much everyone else, including Craft Poker Co.'s investors.

Here are the public messages, followed with the SQL query I used to get the private messages (which I'm not posting here, because they're private):

mb2=> select id, received_at at time zone 'america/los_angeles', player_id, message from public_table_messages where hand_id = 421590 order by received_at;
    id    |          timezone          | player_id |                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                              message                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                              
----------+----------------------------+-----------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 11404101 | 2024-09-05 17:18:23.080272 |           | {"Dealing": ["800 1600 (200) Razz", 0, "StudLimit", 2, true, 421590, true, false, 0]}
 11404102 | 2024-09-05 17:18:25.087421 |           | {"EveryoneAntes": 200}
 11404103 | 2024-09-05 17:18:25.092656 |           | {"BeginRound": [0, null, 200, 800, false, 137]}
 11404104 | 2024-09-05 17:18:25.097498 |           | {"Status": {"board": {"grid": null, "cards": {"cards": []}}, "button": 4, "players": [{"id": 10, "seat": 0, "cards": {"cards": ["UnknownDown", "UnknownDown", {"Up": {"Natural": {"rank": 8, "suit": "Club"}}}]}, "chips": 29925, "action": 200, "status": "Live", "lammers": null, "pot_size": null, "vacation": false, "pot_number": null, "n_rebuys_remaining": 0}, {"id": 9, "seat": 1, "cards": {"cards": ["UnknownDown", "UnknownDown", {"Up": {"Natural": {"rank": 7, "suit": "Club"}}}]}, "chips": 166025, "action": 200, "status": "Live", "lammers": null, "pot_size": null, "vacation": false, "pot_number": null, "n_rebuys_remaining": 0}, {"id": 37, "seat": 2, "cards": {"cards": ["UnknownDown", "UnknownDown", {"Up": {"Natural": {"rank": 11, "suit": "Club"}}}]}, "chips": 49200, "action": 200, "status": "Live", "lammers": null, "pot_size": null, "vacation": false, "pot_number": null, "n_rebuys_remaining": null}, {"id": 13, "seat": 3, "cards": {"cards": ["UnknownDown", "UnknownDown", {"Up": {"Natural": {"rank": 11, "suit": "Diamond"}}}]}, "chips": 51550, "action": 200, "status": "Live", "lammers": null, "pot_size": null, "vacation": false, "pot_number": null, "n_rebuys_remaining": 0}, {"id": 14, "seat": 4, "cards": {"cards": ["UnknownDown", "UnknownDown", {"Up": {"Natural": {"rank": 10, "suit": "Heart"}}}]}, "chips": 65900, "action": 200, "status": "Live", "lammers": null, "pot_size": null, "vacation": false, "pot_number": null, "n_rebuys_remaining": 0}, {"id": 20, "seat": 5, "cards": {"cards": ["UnknownDown", "UnknownDown", {"Up": {"Natural": {"rank": 3, "suit": "Heart"}}}]}, "chips": 56200, "action": 200, "status": "Live", "lammers": null, "pot_size": null, "vacation": false, "pot_number": null, "n_rebuys_remaining": null}], "solo_ante": null, "action_type": "Betting", "next_to_act": 3, "dormant_button": null, "cards_are_settable": false}}
 11404105 | 2024-09-05 17:18:25.1022   |           | {"BringIn": [20000, 200, 800, "2024-09-06T00:18:45.086230225Z", 13, 20]}
 11404106 | 2024-09-05 17:18:28.852813 |           | {"BringsIn": [13, 200, false, null]}
 11404107 | 2024-09-05 17:18:28.857455 |           | {"Remind": [20000, 200, "2024-09-06T00:18:48.851427271Z", 14, 20]}
 11404108 | 2024-09-05 17:18:32.872741 |           | {"Folds": [14, false, null, null]}
 11404109 | 2024-09-05 17:18:32.877361 |           | {"Remind": [20000, 200, "2024-09-06T00:18:52.871384618Z", 20, 20]}
 11404110 | 2024-09-05 17:18:35.268102 |           | {"Calls": [20, null, false, 400]}
 11404111 | 2024-09-05 17:18:35.273057 |           | {"Folds": [10, false, null, null]}
 11404112 | 2024-09-05 17:18:35.279559 |           | {"Remind": [20000, 200, "2024-09-06T00:18:55.266692001Z", 9, 20]}
 11404113 | 2024-09-05 17:18:55.268973 |           | {"Vacationed": 9}
 11404114 | 2024-09-05 17:18:55.275177 |           | {"Folds": [9, true, null, "Vacation"]}
 11404115 | 2024-09-05 17:18:55.280394 |           | {"Folds": [37, false, null, null]}
 11404116 | 2024-09-05 17:18:55.285454 |           | {"BeginRound": [1, null, 800, 0, false, 138]}
 11404117 | 2024-09-05 17:18:55.290222 |           | {"Status": {"board": {"grid": null, "cards": {"cards": []}}, "button": 4, "players": [{"id": 10, "seat": 0, "cards": {"cards": []}, "chips": 29925, "action": 200, "status": "Folded", "lammers": null, "pot_size": null, "vacation": false, "pot_number": null, "n_rebuys_remaining": 0}, {"id": 9, "seat": 1, "cards": {"cards": []}, "chips": 166025, "action": 200, "status": "Folded", "lammers": null, "pot_size": null, "vacation": true, "pot_number": null, "n_rebuys_remaining": 0}, {"id": 37, "seat": 2, "cards": {"cards": []}, "chips": 49200, "action": 200, "status": "Folded", "lammers": null, "pot_size": null, "vacation": false, "pot_number": null, "n_rebuys_remaining": null}, {"id": 13, "seat": 3, "cards": {"cards": ["UnknownDown", "UnknownDown", {"Up": {"Natural": {"rank": 11, "suit": "Diamond"}}}, {"Up": {"Natural": {"rank": 10, "suit": "Club"}}}]}, "chips": 51350, "action": 400, "status": "Live", "lammers": null, "pot_size": null, "vacation": false, "pot_number": null, "n_rebuys_remaining": 0}, {"id": 14, "seat": 4, "cards": {"cards": []}, "chips": 65900, "action": 200, "status": "Folded", "lammers": null, "pot_size": null, "vacation": false, "pot_number": null, "n_rebuys_remaining": 0}, {"id": 20, "seat": 5, "cards": {"cards": ["UnknownDown", "UnknownDown", {"Up": {"Natural": {"rank": 3, "suit": "Heart"}}}, {"Up": {"Natural": {"rank": 10, "suit": "Spade"}}}]}, "chips": 56000, "action": 400, "status": "Live", "lammers": null, "pot_size": null, "vacation": false, "pot_number": null, "n_rebuys_remaining": null}], "solo_ante": null, "action_type": "Betting", "next_to_act": 5, "dormant_button": null, "cards_are_settable": false}}
 11404118 | 2024-09-05 17:18:55.295856 |           | {"Remind": [20000, 0, "2024-09-06T00:19:15.267195177Z", 20, 20]}
 11404119 | 2024-09-05 17:19:01.671687 |           | {"Bets": [20, 800, null, false]}
 11404120 | 2024-09-05 17:19:01.676903 |           | {"Remind": [20000, 800, "2024-09-06T00:19:21.670199040Z", 13, 20]}
 11404121 | 2024-09-05 17:19:03.525404 |           | {"Calls": [13, null, false, 1200]}
 11404122 | 2024-09-05 17:19:03.530385 |           | {"BeginRound": [2, null, 1600, 0, false, 139]}
 11404123 | 2024-09-05 17:19:03.534983 |           | {"Status": {"board": {"grid": null, "cards": {"cards": []}}, "button": 4, "players": [{"id": 10, "seat": 0, "cards": {"cards": []}, "chips": 29925, "action": 200, "status": "Folded", "lammers": null, "pot_size": null, "vacation": false, "pot_number": null, "n_rebuys_remaining": 0}, {"id": 9, "seat": 1, "cards": {"cards": []}, "chips": 166025, "action": 200, "status": "Folded", "lammers": null, "pot_size": null, "vacation": true, "pot_number": null, "n_rebuys_remaining": 0}, {"id": 37, "seat": 2, "cards": {"cards": []}, "chips": 49200, "action": 200, "status": "Folded", "lammers": null, "pot_size": null, "vacation": false, "pot_number": null, "n_rebuys_remaining": null}, {"id": 13, "seat": 3, "cards": {"cards": ["UnknownDown", "UnknownDown", {"Up": {"Natural": {"rank": 11, "suit": "Diamond"}}}, {"Up": {"Natural": {"rank": 10, "suit": "Club"}}}, {"Up": {"Natural": {"rank": 5, "suit": "Club"}}}]}, "chips": 50550, "action": 1200, "status": "Live", "lammers": null, "pot_size": null, "vacation": false, "pot_number": null, "n_rebuys_remaining": 0}, {"id": 14, "seat": 4, "cards": {"cards": []}, "chips": 65900, "action": 200, "status": "Folded", "lammers": null, "pot_size": null, "vacation": false, "pot_number": null, "n_rebuys_remaining": 0}, {"id": 20, "seat": 5, "cards": {"cards": ["UnknownDown", "UnknownDown", {"Up": {"Natural": {"rank": 3, "suit": "Heart"}}}, {"Up": {"Natural": {"rank": 10, "suit": "Spade"}}}, {"Up": {"Natural": {"rank": 9, "suit": "Spade"}}}]}, "chips": 55200, "action": 1200, "status": "Live", "lammers": null, "pot_size": null, "vacation": false, "pot_number": null, "n_rebuys_remaining": null}], "solo_ante": null, "action_type": "Betting", "next_to_act": 5, "dormant_button": null, "cards_are_settable": false}}
 11404124 | 2024-09-05 17:19:03.540215 |           | {"Remind": [20000, 0, "2024-09-06T00:19:23.523892395Z", 20, 20]}
 11404125 | 2024-09-05 17:19:05.940925 |           | {"Bets": [20, 1600, null, false]}
 11404126 | 2024-09-05 17:19:05.945483 |           | {"Remind": [20000, 1600, "2024-09-06T00:19:25.939506450Z", 13, 20]}
 11404127 | 2024-09-05 17:19:11.857438 |           | {"RaisesNtoM": [13, 1600, 3200, null, false, 4400]}
 11404128 | 2024-09-05 17:19:11.862337 |           | {"Remind": [20000, 1600, "2024-09-06T00:19:31.856048372Z", 20, 20]}
 11404129 | 2024-09-05 17:19:16.569866 |           | {"RaisesNtoM": [20, 1600, 4800, null, false, 6000]}
 11404130 | 2024-09-05 17:19:16.574761 |           | {"Remind": [20000, 1600, "2024-09-06T00:19:36.568385238Z", 13, 20]}
 11404131 | 2024-09-05 17:19:27.900865 |           | {"Chat": [13, "Why?"]}
 11404132 | 2024-09-05 17:19:31.720432 |           | {"Calls": [13, null, false, 6000]}
 11404133 | 2024-09-05 17:19:31.725413 |           | {"BeginRound": [3, null, 1600, 0, false, 140]}
 11404134 | 2024-09-05 17:19:31.731221 |           | {"Status": {"board": {"grid": null, "cards": {"cards": []}}, "button": 4, "players": [{"id": 10, "seat": 0, "cards": {"cards": []}, "chips": 29925, "action": 200, "status": "Folded", "lammers": null, "pot_size": null, "vacation": false, "pot_number": null, "n_rebuys_remaining": 0}, {"id": 9, "seat": 1, "cards": {"cards": []}, "chips": 166025, "action": 200, "status": "Folded", "lammers": null, "pot_size": null, "vacation": true, "pot_number": null, "n_rebuys_remaining": 0}, {"id": 37, "seat": 2, "cards": {"cards": []}, "chips": 49200, "action": 200, "status": "Folded", "lammers": null, "pot_size": null, "vacation": false, "pot_number": null, "n_rebuys_remaining": null}, {"id": 13, "seat": 3, "cards": {"cards": ["UnknownDown", "UnknownDown", {"Up": {"Natural": {"rank": 11, "suit": "Diamond"}}}, {"Up": {"Natural": {"rank": 10, "suit": "Club"}}}, {"Up": {"Natural": {"rank": 5, "suit": "Club"}}}, {"Up": {"Natural": {"rank": 8, "suit": "Heart"}}}]}, "chips": 45750, "action": 6000, "status": "Live", "lammers": null, "pot_size": null, "vacation": false, "pot_number": null, "n_rebuys_remaining": 0}, {"id": 14, "seat": 4, "cards": {"cards": []}, "chips": 65900, "action": 200, "status": "Folded", "lammers": null, "pot_size": null, "vacation": false, "pot_number": null, "n_rebuys_remaining": 0}, {"id": 20, "seat": 5, "cards": {"cards": ["UnknownDown", "UnknownDown", {"Up": {"Natural": {"rank": 3, "suit": "Heart"}}}, {"Up": {"Natural": {"rank": 10, "suit": "Spade"}}}, {"Up": {"Natural": {"rank": 9, "suit": "Spade"}}}, {"Up": {"Natural": {"rank": 13, "suit": "Diamond"}}}]}, "chips": 50400, "action": 6000, "status": "Live", "lammers": null, "pot_size": null, "vacation": false, "pot_number": null, "n_rebuys_remaining": null}], "solo_ante": null, "action_type": "Betting", "next_to_act": 5, "dormant_button": null, "cards_are_settable": false}}
 11404135 | 2024-09-05 17:19:31.736038 |           | {"Remind": [20000, 0, "2024-09-06T00:19:51.719071112Z", 20, 20]}
 11404136 | 2024-09-05 17:19:36.551616 |           | {"Bets": [20, 1600, null, false]}
 11404137 | 2024-09-05 17:19:36.556594 |           | {"Remind": [20000, 1600, "2024-09-06T00:19:56.550178648Z", 13, 20]}
 11404138 | 2024-09-05 17:19:47.652063 |           | {"Folds": [13, false, null, null]}
 11404139 | 2024-09-05 17:19:47.658307 |           | {"ReturnUncalled": [20, 1600]}
 11404140 | 2024-09-05 17:19:47.680022 |           | {"EndOfHand": {"penalties": [], "player_amounts": [[[20, [12800, 0]]]], "split_hand_names": null, "player_revelations": [{"player_id": 20, "revelation": "DoesNotShow"}]}}
(40 rows)

mb2=> select id, received_at at time zone 'america/los_angeles', message from private_table_messages where hand_id = 421590 and player_id = 13 order by received_at;

[…]

@ctm ctm added bug Something isn't working can't reproduce Can't reproduce high priority Should be done fairly soon labels Sep 6, 2024
@ctm ctm self-assigned this Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working can't reproduce Can't reproduce high priority Should be done fairly soon
Projects
None yet
Development

No branches or pull requests

1 participant