Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refreshing post-loss table window resulted in white screen #1480

Open
ctm opened this issue Aug 2, 2024 · 6 comments
Open

Refreshing post-loss table window resulted in white screen #1480

ctm opened this issue Aug 2, 2024 · 6 comments
Assignees
Labels
bug Something isn't working easy Trivial to do (even when tired!) and semi-worthwhile high priority Should be done fairly soon

Comments

@ctm
Copy link
Owner

ctm commented Aug 2, 2024

Fix so after a player busts, the table window can be refreshed.

After this evening's game, I refreshed my table accidentally (I meant to refresh a different window) and got a white screen. There was nothing in the JavaScript console to suggest that anything had failed. Inspecting elements showed there was a notice (which wasn't displayed) which said "this table is no longer available". My guess is that the other player had already bust, but that the game hadn't completely shut down.

This may not be a regression. It may just be a race-condition nobody has hit (or at least reported).

@ctm ctm added bug Something isn't working high priority Should be done fairly soon easy Trivial to do (even when tired!) and semi-worthwhile regression Something that formerly worked labels Aug 2, 2024
@ctm ctm self-assigned this Aug 2, 2024
@ctm ctm removed the regression Something that formerly worked label Aug 2, 2024
@ctm
Copy link
Owner Author

ctm commented Aug 2, 2024

FWIW, I refreshed again after writing up this issue and got the tournament summary info that one is supposed to get after a tournament has finished. Now that I've slept on it, I'm stripping regression, since I'm leaning on this being a race condition.

@ctm
Copy link
Owner Author

ctm commented Aug 2, 2024

Nothing in the text logs:

ubuntu@ip-172-30-2-88:~$ sudo docker logs -t mb2 | egrep 'WARN|ERROR' | grep -v 'Illegal SNI hostname'
2024-08-02T02:07:46.566066198Z messages: []
2024-08-02T07:18:35.197227078Z WARN  [rustls::common_state] TLS alert warning received: AlertMessagePayload { level: Warning, description: CloseNotify }

I will look in the db logs, but there is likely to be little to no data to observe. We deliberately try to log very little about non-playing users, and log nothing for observers so that we can support 10,000 observers joining "at once" on our tiny servers (hmmm… now that I think about it, I should load-test to make sure that the additional text logging doesn't throttle us. I doubt it would, but only one way to find out #1481).

@ctm
Copy link
Owner Author

ctm commented Sep 24, 2024

I wound up with a white table again post loss and I'm not even sure that I refreshed. I may have. FWIW, this was a two table tournament and it was down to the final table (6064). It may make sense to see which table I started at.

@ctm
Copy link
Owner Author

ctm commented Sep 24, 2024

RIght now I can click on the 6064 link on the lobby and get a table that works fine, but once I refresh it, it goes white.

@ctm
Copy link
Owner Author

ctm commented Sep 24, 2024

The tournament ended, but if I use the table link, I get a white screen instead of something telling me that the table is no longer in use.

@ctm
Copy link
Owner Author

ctm commented Sep 24, 2024

This also happens with table 6063, but if I go to 6062, it says "table is no longer active" (like it should).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working easy Trivial to do (even when tired!) and semi-worthwhile high priority Should be done fairly soon
Projects
None yet
Development

No branches or pull requests

1 participant