Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dealer's Choice uses separate hand for game selection #1479

Open
ctm opened this issue Aug 1, 2024 · 0 comments
Open

Dealer's Choice uses separate hand for game selection #1479

ctm opened this issue Aug 1, 2024 · 0 comments
Assignees
Labels
chore Maintenance or other non-bug, non-feature

Comments

@ctm
Copy link
Owner

ctm commented Aug 1, 2024

Consider refactoring Dealer's Choice so that the game that is selected is done in the same hand as the game is played.

I added Dealer's Choice during the WSOP-Style series in 2023 and cut at least one corner to get it done "in time" (and even then it was late). Specifically, Mb2 currently treats game selection as a hand unto itself (i.e., getting its own hand number), rather than a preamble to the first hand of the new game. I think that's a poor choice, although I haven't really thought about it enough to be sure. There are currently no known bugs associated with how its implemented, but we also don't implement hand histories. When we do implement hand histories, if we don't refactor, the game choice will be a separate hand.

If I do choose to merte them, doing so is easy in principle, but shouldn't be done until we have a nice way to use the database to do regressive tests, since it would be trivial to introduce a subtle bug.

@ctm ctm added the chore Maintenance or other non-bug, non-feature label Aug 1, 2024
@ctm ctm self-assigned this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance or other non-bug, non-feature
Projects
None yet
Development

No branches or pull requests

1 participant