Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to redraw to n-seated final table #1469

Open
3 of 6 tasks
ctm opened this issue Jul 14, 2024 · 2 comments
Open
3 of 6 tasks

Add ability to redraw to n-seated final table #1469

ctm opened this issue Jul 14, 2024 · 2 comments
Assignees
Labels
easy Trivial to do (even when tired!) and semi-worthwhile enhancement New feature or request high priority Should be done fairly soon

Comments

@ctm
Copy link
Owner

ctm commented Jul 14, 2024

Make it so a the final table can seat a different number of players than the other tables.

In theory, this is trivial, however, currently if we add a new field to TournamentStructure, it requires trivial changes throughout the structure files. Since the structure files shouldn't exist (because that info should come from the database), I've let this problem fester. It's now slightly worse than it used to be, because I used to be able to use a sed command to add the field, but now with all the macro invocations, I may have to add the field in a few places where sed can't do it for me.

So, I'm going to see how long it takes to add the field and get everything compiling again. If I can do that in under a half hour, I'll probably proceed to implement the functionality today, even though I still have a bunch of packing to do for BARGE.

  • Add final_table_handed to TournamentStructure as an Option<u8>
  • Make it be None everywhere
  • Make it be the correct value for the three WYWAB 2024 tournaments where it matters
  • Use that field to determine when to combine and redraw
  • Use that field to figure out how many tables to start with at the beginning
  • Make it so structure sheets let people know when this is going to happen
@ctm ctm added enhancement New feature or request high priority Should be done fairly soon easy Trivial to do (even when tired!) and semi-worthwhile labels Jul 14, 2024
@ctm ctm self-assigned this Jul 14, 2024
@ctm
Copy link
Owner Author

ctm commented Jul 14, 2024

I was FOS. It took two invocations of sed, one edit of a single macro and a hand-edit of wrgpt.rs.

@ctm
Copy link
Owner Author

ctm commented Jul 14, 2024

So, I did the "obvious" work to support expanding the table size, but the graphical UI doesn't show the new seat. My guess is the graphical UI determines the number of seats from the structure in a way that doesn't take the new final_table_handed into account. This will be easy to find and fix, but we're pretty close to this evening's tournament.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy Trivial to do (even when tired!) and semi-worthwhile enhancement New feature or request high priority Should be done fairly soon
Projects
None yet
Development

No branches or pull requests

1 participant